Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependency versions #6

Closed
kdpsingh opened this issue Aug 14, 2023 · 2 comments
Closed

Updating dependency versions #6

kdpsingh opened this issue Aug 14, 2023 · 2 comments

Comments

@kdpsingh
Copy link
Contributor

Currently, Cleaner.jl depends on Tables (version == "1") and PrettyTables (version == "1).

However, because DataFrames.jl relies on PrettyTables v2.1, Cleaner.jl currently forces DataFrames.jl to be downgraded to quite an older version (v1.3.6) in order for these requirements to be satisfied.

Can we change the compat for PrettyTables to version == "2" or "1, 2" if you want to allow for v1 as well?

Thanks for considering.

kdpsingh pushed a commit to kdpsingh/Cleaner.jl that referenced this issue Aug 15, 2023
Changed PrettyTables compat to allow for version 2+ (in addition to v1+), and bumped version to 1.0.3.

This proposed change is intended to address TheRoniOne#6.
@kdpsingh
Copy link
Contributor Author

Just bumping this. Thanks for taking a look.

TheRoniOne pushed a commit that referenced this issue Aug 22, 2023
Changed PrettyTables compat to allow for version 2+ (in addition to v1+), and bumped version to 1.0.3.

This proposed change is intended to address #6.
@TheRoniOne
Copy link
Owner

Thanks for letting me know, just released v1.0.3 fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants