Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make application-layer f_port check stricter #693

Merged
merged 2 commits into from
May 15, 2019
Merged

Make application-layer f_port check stricter #693

merged 2 commits into from
May 15, 2019

Conversation

johanstokking
Copy link
Member

Summary

Closes #692

Changes

Turns out that #692 can be closed simply with validation

@johanstokking johanstokking added the compat/api This could affect API compatibility label May 15, 2019
@johanstokking johanstokking added this to the May 2019 milestone May 15, 2019
@johanstokking johanstokking requested a review from rvolosatovs May 15, 2019 12:30
@johanstokking johanstokking requested a review from htdvisser as a code owner May 15, 2019 12:30
@johanstokking johanstokking self-assigned this May 15, 2019
@johanstokking johanstokking force-pushed the feature/692-as-check-f-port branch from 1e4e5ca to 0641e27 Compare May 15, 2019 12:32
@johanstokking
Copy link
Member Author

Looks like our generated documentation and JS SDK definition doesn't handle not_in

@htdvisser
Copy link
Contributor

I'll see what's up with that not_in in the documentation.

@johanstokking johanstokking force-pushed the feature/692-as-check-f-port branch from 0641e27 to eb1f74f Compare May 15, 2019 18:52
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 73.54% when pulling eb1f74f on feature/692-as-check-f-port into c8bc482 on master.

@johanstokking johanstokking merged commit 4fa329a into master May 15, 2019
@johanstokking johanstokking deleted the feature/692-as-check-f-port branch May 15, 2019 20:49
@htdvisser
Copy link
Contributor

FYI: That documentation for not_in should be fixed with pseudomuto/protoc-gen-doc#392

@rvolosatovs
Copy link
Contributor

I'll update protoc image once it's merged and a new version is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

@htdvisser htdvisser Awaiting requested review from htdvisser

Assignees

@johanstokking johanstokking

Labels
compat/api This could affect API compatibility
Projects
None yet
Milestone
May 2019
Development

Successfully merging this pull request may close these issues.

Check FPort on downlink
4 participants
@johanstokking @htdvisser @coveralls @rvolosatovs