Update license, dependencies, and environmental variable loading #14
Conversation
jniles
changed the title
|
@sfount can you do a test of this branch before a merge to master? |
This commit updates bhima's license to an SPDX valid license identifier (we are still GPL version 2). It also updates the outdated dependencies in the package.json.
This commit removes the deprecated dependency on gulp-minify-css and replaces it with gulp-cssnano in the build. It also fixes a few css rules discovered by the build process.
This commit migrates all the server code to use the dotenv npm module to manage environmental variables. For reference, a ".env.sample" file is included and should be customized to ".env.production" for production mode and ".env.development" for the development environment. All previous configuration files have been removed. Additionally, much ancient commented code has been cleaned up from the database library code.
|
@jniles - missed this message 👎, will have it in this morning. |
|
👍 |
|
Everything looks good; I think ensuring the default environment variables are configured would be a good next step for some build/ install script (for the future). Before this can be pulled all references to
Cheers. |
|
For reference (@IMA-WorldHealth/local-contributors), EDIT also, thanks @sfount for the review. Will get these changes in soon. |
This commit fixes a danging config not updated to use process.env. This commit ensure the budget module properly looks up the environmental variables from the `process` object. Additionally, this commit ensures that the `/bin` directory is deleted and recreated when running the gulp-build or `npm run app` commands.
jniles
force-pushed
the
patches-update-dependencies
branch
from
5b9c11c to
d354e01
Compare
|
@sfount, the fixes you requested have landed in this branch. Thanks! |
Update license, dependencies, and environmental variable loading
This commit updates bhima's license to an SPDX valid license identifier (we are still GPL version 2). It also updates the outdated dependencies in the package.json. In particular, we no longer use the deprecated
gulp-minify-cssand instead usegulp-cssnano. See this page. Closes #15.Breaking Change This PR depends on the dotenv npm package to manage environmental variables. You must have a
.env.productionfile in the top level folder of the repository to run the application usingnpm run app. To run tests, you must have a.env.developmentfile. Closes #4.