perf(users): use GROUP_CONCAT for roles/depots #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses GROUP_CONCAT() to ensure that roles and depots are assigned to users instead of using JavaScript Objects. This is also helpful because we can order the values in alphabetical order. Closes Third-Culture-Software#4136
This commit achieves the final part of Third-Culture-Software#4021 by adding the cashboxes a user has access to onto the user grid.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 13, 2020
4165: perf(users): use GROUP_CONCAT for roles/depots r=jniles a=jniles Uses GROUP_CONCAT() to ensure that roles and depots are assigned to users instead of using JavaScript Objects. This is also helpful because we can order the values in alphabetical order. Closes #4136 Co-authored-by: Jonathan Niles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses GROUP_CONCAT() to ensure that roles and depots are assigned to users instead of using JavaScript Objects. This is also helpful because we can order the values in alphabetical order.
It looks like this:
Closes #4136