Fix payroll currency bug #7979
Open
Fix payroll currency bug #7979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the `date_embauche` with `hiring_date` for better English consistency. Closes Third-Culture-Software#7821.
Uses the employee's UUID to filter the employee registry from the multiple payroll registry, rather than the human readable reference.
Improves the "putOnWaitingList" modal by using the modal itself to send the HTTP request for the confirmation. This allows the parent controller to have a more standard flow. Useless code was also removed, in addition to improving the variable naming to better English names.
Complete rewrite of the multiple_payroll payment configuration modal to be less brittle and provide a better user experience. I've completely removed the option for the user to set the currency since no production sites were using it in practice, and it had some serious bugs. This reduces the number of imports into the modal and removes the need to do any currency conversion. Additionally, I've provided additionally context in the modal about the employee, their grade, function, number of dependents, etc., to give the user all the context needed for configuration of the employee. Closes Third-Culture-Software#7966.
Improves the UI of the config modal with units for the different days/people presented to the user.
I am not sure when we added the canise-lite to the repository, but I cannot find where it is used. Removing for that reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the payroll configuration currency bug reported in #7966. It does so be completely removing the currency selection (see discussions in #7966 and #4956 (comment)). Some small touches include making the translation and function keys all English values.
Routing Improvements
I've improved the ui-routing of the
multiple_payrollmodule so that only minimal information is passed into theconfigmodal and the both the parent and modal controllers are less reliant on parsing thevm.latestViewValues. There is still some work to be done in this area to completely eliminate this dependency in themultiple_payrollcontroller, but the configuration modal is now state agnostic.UI Improvements
I've added additional contextual information to the
ConfigPaymentModalfor the user to orient them about which employee is being configured. In particular, the employee name, grade, and number of dependents are all prominently displayed. See below:Closes #7966.