Remove Bytes impl for arrays and slices
#415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update_length function was never correctly implemented for them which causes issues with methods such as TcpStream::recv_n.
This should be done by the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
Bytesimpl for arrays and slicesThe
update_lengthfunction was never correctly implemented for themwhich causes issues with methods such as
TcpStream::recv_n.Closes #308 as this is no longer desidered.
Closes #408 as this is no longer possible.
Don't remove empty buffers in
TcpStream::try_recv_vectored.Closes #407.