Exception mapper naming (#1211)

* Fix typo in class and file name "Exeption" -> "Exception" * And rename the test * IDE1006 Naming rule violation: These words must begin with upper case characters: {should_*} Fix name violation --------- Co-authored-by: Anthony Steele <[email protected]> Co-authored-by: raman-m <[email protected]>
ThreeMammals · Sep 22, 2023 · 455d7d3 · 455d7d3
1 parent 818d1fc
commit 455d7d3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/src/Ocelot/DependencyInjection/OcelotBuilder.cs b/src/Ocelot/DependencyInjection/OcelotBuilder.cs
@@ -160,7 +160,7 @@ public OcelotBuilder(IServiceCollection services, IConfiguration configurationRo
             Services.TryAddSingleton<IDownstreamRequestCreator, DownstreamRequestCreator>();
             Services.TryAddSingleton<IFrameworkDescription, FrameworkDescription>();
             Services.TryAddSingleton<IQoSFactory, QoSFactory>();
-            Services.TryAddSingleton<IExceptionToErrorMapper, HttpExeptionToErrorMapper>();
+            Services.TryAddSingleton<IExceptionToErrorMapper, HttpExceptionToErrorMapper>();
             Services.TryAddSingleton<IVersionCreator, HttpVersionCreator>();
 
             //add security

diff --git a/...ot/Requester/HttpExeptionToErrorMapper.cs → ...t/Requester/HttpExceptionToErrorMapper.cs b/...ot/Requester/HttpExeptionToErrorMapper.cs → ...t/Requester/HttpExceptionToErrorMapper.cs
@@ -8,11 +8,11 @@
 
 namespace Ocelot.Requester
 {
-    public class HttpExeptionToErrorMapper : IExceptionToErrorMapper
+    public class HttpExceptionToErrorMapper : IExceptionToErrorMapper
     {
         private readonly Dictionary<Type, Func<Exception, Error>> _mappers;
 
-        public HttpExeptionToErrorMapper(IServiceProvider serviceProvider)
+        public HttpExceptionToErrorMapper(IServiceProvider serviceProvider)
         {
             _mappers = serviceProvider.GetService<Dictionary<Type, Func<Exception, Error>>>();
         }

diff --git a/...quester/HttpExeptionToErrorMapperTests.cs → ...uester/HttpExceptionToErrorMapperTests.cs b/...quester/HttpExeptionToErrorMapperTests.cs → ...uester/HttpExceptionToErrorMapperTests.cs
@@ -16,52 +16,52 @@
 
 namespace Ocelot.UnitTests.Requester
 {
-    public class HttpExeptionToErrorMapperTests
+    public class HttpExceptionToErrorMapperTests
     {
-        private HttpExeptionToErrorMapper _mapper;
+        private HttpExceptionToErrorMapper _mapper;
         private readonly ServiceCollection _services;
 
-        public HttpExeptionToErrorMapperTests()
+        public HttpExceptionToErrorMapperTests()
         {
             _services = new ServiceCollection();
             var provider = _services.BuildServiceProvider();
-            _mapper = new HttpExeptionToErrorMapper(provider);
+            _mapper = new HttpExceptionToErrorMapper(provider);
         }
 
         [Fact]
-        public void should_return_default_error_because_mappers_are_null()
+        public void Should_return_default_error_because_mappers_are_null()
         {
             var error = _mapper.Map(new Exception());
 
             error.ShouldBeOfType<UnableToCompleteRequestError>();
         }
 
         [Fact]
-        public void should_return_request_canceled()
+        public void Should_return_request_canceled()
         {
             var error = _mapper.Map(new OperationCanceledException());
 
             error.ShouldBeOfType<RequestCanceledError>();
         }
 
         [Fact]
-        public void should_return_ConnectionToDownstreamServiceError()
+        public void Should_return_ConnectionToDownstreamServiceError()
         {
             var error = _mapper.Map(new HttpRequestException());
 
             error.ShouldBeOfType<ConnectionToDownstreamServiceError>();
         }
 
         [Fact]
-        public void should_return_request_canceled_for_subtype()
+        public void Should_return_request_canceled_for_subtype()
         {
             var error = _mapper.Map(new SomeException());
 
             error.ShouldBeOfType<RequestCanceledError>();
         }
 
         [Fact]
-        public void should_return_error_from_mapper()
+        public void Should_return_error_from_mapper()
         {
             var errorMapping = new Dictionary<Type, Func<Exception, Error>>
             {
@@ -72,7 +72,7 @@ public void should_return_error_from_mapper()
 
             var provider = _services.BuildServiceProvider();
 
-            _mapper = new HttpExeptionToErrorMapper(provider);
+            _mapper = new HttpExceptionToErrorMapper(provider);
 
             var error = _mapper.Map(new TaskCanceledException());