Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read Downstream url error #1026

Closed
winlj opened this issue Sep 24, 2019 · 4 comments · Fixed by #2067
Closed

read Downstream url error #1026

winlj opened this issue Sep 24, 2019 · 4 comments · Fixed by #2067
Assignees
@raman-m
Labels
bug Identified as a potential bug Consul Service discovery by Consul merged Issue has been merged to dev and is waiting for the next release Service Discovery Ocelot feature: Service Discovery Spring'24 Spring 2024 release
Milestone
Spring'24

Comments

@winlj
Copy link

winlj commented Sep 24, 2019

message: Downstream url is http://business-a:3007/code/api/test/printf
uri is nodename , why not Downstream ip address?

Version:13.5.2 uri is nodename
Version:13.5.1 uri is Downstream ip

consul client reg:---->consul agent -bind=192.168.0.78 -client=192.168.0.78 -data-dir=/home/tmp/consul -node=business-a -join 192.168.0.26

Specifications

  • Version:13.5.2
  • Platform:
  • Subsystem:
@Leandropintogit
Copy link

Hi

Its a known issue

#909

Leandropintogit pushed a commit to Leandropintogit/Ocelot that referenced this issue Oct 29, 2019
Fix - ThreeMammals#954 ThreeMammals#957 ThreeMammals#995 ThreeMammals…
99701cc 
…#1016 ThreeMammals#1026 ThreeMammals#934
Leandropintogit pushed a commit to Leandropintogit/Ocelot that referenced this issue Oct 29, 2019
Fix - ThreeMammals#954 ThreeMammals#957 ThreeMammals#995 ThreeMammals…
09115e7 
…#1016 ThreeMammals#1026 ThreeMammals#934
@raman-m
Copy link
Member

raman-m commented Mar 17, 2024

Duplicate of #909

@raman-m raman-m marked this as a duplicate of #909 Mar 17, 2024
@raman-m
Copy link
Member

raman-m commented Mar 17, 2024

Duplicate of #954

@raman-m raman-m marked this as a duplicate of #954 Mar 17, 2024
@raman-m
Copy link
Member

raman-m commented Mar 17, 2024

Will be fixed as a part of #954 and #909

@raman-m raman-m closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2024
@raman-m raman-m reopened this May 15, 2024
@raman-m raman-m added bug Identified as a potential bug Service Discovery Ocelot feature: Service Discovery Consul Service discovery by Consul Spring'24 Spring 2024 release labels May 15, 2024
@raman-m raman-m added this to the March-April'24 milestone May 15, 2024
@raman-m raman-m mentioned this issue May 15, 2024
Merged
@raman-m raman-m linked a pull request May 15, 2024 that will close this issue
#954 #957 #1026 Customize Consul services creation in Consul service discovery provider #2067
Merged
raman-m added a commit that referenced this issue May 27, 2024
@raman-m @RaynaldM
#954 #957 #1026 Customize Consul services creation in Consul servic…
34cb3eb 
…e discovery provider (#2067)

* Interfaces folder and namespace

* `IConsulServiceBuilder` interface vs `ConsulServiceBuilder` class

* Inject services into `ConsulServiceBuilder`

* Extend `IConsulServiceBuilder` interface

* Finalize design of the customization.
No JSON options because `ServiceDiscoveryProvider` are generalized for all types of providers

* Remove BDDfy in favor of AAA pattern

* Refactor original unit tests

* Rename to `DefaultConsulServiceBuilder`

* Update src/Ocelot.Provider.Consul/DefaultConsulServiceBuilder.cs

Update `IsValid(ServiceEntry entry)`

Co-authored-by: Raynald Messié <[email protected]>

* Code review by @RaynaldM

* Read the node instance from `ServiceEntry`.
If it is null, search for a node in the common collection.

* Refactor `OcelotBuilderExtensionsTests`

* The generic `AddConsul<TServiceBuilder>(IOcelotBuilder)` method

* Rename to `ConsulTests`

* Unit tests: 100% coverage

* Move to `ServiceDiscovery` folder

* DRY: GivenServiceEntry, GivenRoute

* Convert to file-scoped namespace

* Inherit from `Steps`

* Refactor acceptance tests

* Acceptance test for #954 user scenario

* Move "Store Configuration in Consul" to "Service Discovery"

* Feature docs

---------

Co-authored-by: Raynald Messié <[email protected]>
@raman-m raman-m added the merged Issue has been merged to dev and is waiting for the next release label May 27, 2024
@raman-m raman-m self-assigned this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raman-m raman-m

Labels
bug Identified as a potential bug Consul Service discovery by Consul merged Issue has been merged to dev and is waiting for the next release Service Discovery Ocelot feature: Service Discovery Spring'24 Spring 2024 release
Projects
None yet
Milestone
Spring'24
3 participants
@winlj @raman-m @Leandropintogit