Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route -url char missing #1288

Closed
yangbocheng opened this issue Jul 14, 2020 · 5 comments · Fixed by #1335
Closed

route -url char missing #1288

yangbocheng opened this issue Jul 14, 2020 · 5 comments · Fixed by #1335
Assignees
@yangbocheng
Labels
bug Identified as a potential bug merged Issue has been merged to dev and is waiting for the next release

Comments

@yangbocheng
Copy link

yangbocheng commented Jul 14, 2020 •
edited by raman-m
Loading

Route Bug

Steps to Reproduce the Problem

  1. Ocelot run at localhost:9999 with configuration:
{
      "DownstreamPathTemplate": "/cpx/t1/{id}",
      "DownstreamScheme": "http",
      "DownstreamHostAndPorts": [
        {
          "Host": "localhost",
          "Port": 5002
        }
      ],
      "UpstreamPathTemplate": "/safe/{id}",
      "UpstreamHttpMethod": [ "Get" ],
      "AllowAutoRedirect": true
}
  1. Then call http://localhost:9999/safe/3?id1=2312 then log is:
info: Ocelot.Requester.Middleware.HttpRequesterMiddleware[0]
      requestId: 0HM17NUPUA37Q:00000001, previousRequestId: no previous request id, message: 200 (OK) status code, 
request uri: http://localhost:5002/cpx/t1/3?d1=2312

it should be xxxx?id1=2312 , The char i disappeared, id1 → d1

Specifications

  • Version: Ocelot 16.0.1
  • Platform: win10
@yangbocheng yangbocheng changed the title route route -url char missing Jul 14, 2020
@jlukawska jlukawska mentioned this issue Sep 4, 2020
Merged
@jlukawska jlukawska mentioned this issue Mar 10, 2021
Closed
@raman-m raman-m added bug Identified as a potential bug accepted Bug or feature would be accepted as a PR or is being worked on labels Jul 17, 2023
@raman-m
Copy link
Member

raman-m commented Jul 17, 2023 •
edited
Loading

@yangbocheng
Hi xyyyy!
Thanks for your interest in Ocelot!

+ Accepted

...due to ready PR #1335 by @jlukawska

Version: Ocelot 16.0.1

I guess the bug exists in current v19 release too.

@raman-m
Copy link
Member

raman-m commented Aug 9, 2023

@yangbocheng Hey xyyyy!
Yaho-oooo-o! We have bug fixing solution #1335 🎉

Could you check this solution please? 🙏

@yangbocheng
Copy link
Author

it's works now, thanks
image

@raman-m
Copy link
Member

raman-m commented Aug 16, 2023

@yangbocheng commented on Aug 10

Thanks!
Hope, the linked PR will be merged soon.

raman-m added a commit that referenced this issue Sep 22, 2023
@jlukawska @raman-m
#1288 Query string char missing (#1335)
ec85b13 
* fix char missing when query string contains the placeholder name and value

* fix the regex problem with removing a query param when it is not the first

* Remove and Sort Usings

* CA1845 Use span-based 'string.Concat' and 'AsSpan' instead of 'Substring'

* IDE0057 Substring can be simplified.
Use range operator

* IDE0057 Substring can be simplified.
Use range operator

* IDE0042 Variable declaration can be deconstructed.
Deconstruct variable declaration

---------

Co-authored-by: raman-m <[email protected]>
@raman-m raman-m added merged Issue has been merged to dev and is waiting for the next release and removed accepted Bug or feature would be accepted as a PR or is being worked on labels Sep 22, 2023
@raman-m
Copy link
Member

raman-m commented Sep 22, 2023

@yangbocheng Congrats! 🥳

@raman-m raman-m mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangbocheng yangbocheng

Labels
bug Identified as a potential bug merged Issue has been merged to dev and is waiting for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1288 Query string char missing jlukawska/Ocelot
2 participants
@raman-m @yangbocheng