Ocelot can't match placeholders between slashes #2199
Assignees
Labels
Milestone
Comments
raman-m
added
the
accepted
Accepted due open PR #2200 |
raman-m
added
in progress
ggnaegi
added a commit
that referenced
this issue
Nov 17, 2024
* Adding support for placeholder matching between slashes.
* now the behavior is right, it can't be that {finalUrlPath} matches product/products/categories/ since the last slash is part of the template and not the catch-all placeholder
* Performance improvements for EscapeExceptBraces
* EOL: test/Ocelot.UnitTests/DownstreamRouteFinder/UrlMatcher/UrlPathPlaceholderNameAndValueFinderTests.cs
Recover old test for feat 89.
Remove BDDfy from new unit tests.
Apply AAA-pattern.
* Review user scenarios of feat #89 tests
* Refactor unit tests
* Refactor acceptance tests
* Adding documentation for embedded placeholders
* Adding acceptance tests
* Adding suggestions
* again...
* Final code review by @raman-m.
FindGroups method is private, better to return exact type.
Regex optimizations across net6, 7, 8.
XML dev-docs markup review.
Rename 'curly bracket' to 'brace'.
---------
Co-authored-by: Raman Maksimchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior / New Feature
Ocelot should be capable of matching paths that contain placeholders embedded between slashes, such as:
/api/invoices_{url0}/{url1}-{url2}_abcd/{url3}?urlId={url4}.Actual Behavior / Motivation for New Feature
Currently, Ocelot cannot match placeholders embedded between slashes. For example:
/api/test/{url}-2-> request:/api/test/a-2-> the result will incorrectly return{url} = a-2.Steps to Reproduce the Problem
The text was updated successfully, but these errors were encountered: