Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to add a security module #628

Closed
lfzm opened this issue Sep 20, 2018 · 7 comments · Fixed by #629
Closed

Is it possible to add a security module #628

lfzm opened this issue Sep 20, 2018 · 7 comments · Fixed by #629
Labels
feature A new feature help wanted Not actively being worked on. If you plan to contribute, please drop a note. large effort Likely over a week of development effort merged Issue has been merged to dev and is waiting for the next release

Comments

@lfzm
Copy link
Contributor

lfzm commented Sep 20, 2018

Is it possible to add a security module?
IP whitelist, blacklist
AuthorizationToken blacklist
@TomPallister TomPallister added feature A new feature help wanted Not actively being worked on. If you plan to contribute, please drop a note. large effort Likely over a week of development effort labels Sep 20, 2018
@TomPallister
Copy link
Member

@aqa510415008 yes it would be possible. This would be a new feature!

You could have a go at implementing this as a piece of middleware and seeing if it works in your project. Then maybe we could add it to Ocelot?

@lfzm
Copy link
Contributor Author

lfzm commented Sep 21, 2018

@TomPallister I have started to integrate Ocelot. I discussed feasibility with @geffzhang yesterday. IP whitelists and blacklists are configured through Ocelot, and other security components are extensible. When I submit the PR, you can see if it works.

@lfzm lfzm mentioned this issue Sep 21, 2018
Merged
@TomPallister
Copy link
Member

I have reviewed the PR, looks good, changes requested!

Thank you for this. I really appreciate it.

@lfzm
Copy link
Contributor Author

lfzm commented Sep 21, 2018

@TomPallister Thank you for your review, if you can, I add a unit test.

@TomPallister
Copy link
Member

Ok I will wait for tests :)

TomPallister pushed a commit that referenced this issue Sep 25, 2018
@lfzm @TomPallister
add a security module （#628） (#629)
4a8f4c2 
* Add security mechanisms, IP whitelists, blacklists, and extended security interfaces.

* Optimized configuration name

* Fix IP Security Bug

* Repair Security Protection Module Bug

* Add security module unit test

* Optimize log prompts
@TomPallister TomPallister added the merged Issue has been merged to dev and is waiting for the next release label Sep 25, 2018
@lfzm
Copy link
Contributor Author

lfzm commented Sep 26, 2018 •
edited
Loading

Security protection extension for Ocelot AuthorizationToken

Ocelot.Security.AuthorizationToken.EntityFramework

@TomPallister
Copy link
Member

Released in 12.0.1, should be on NuGet soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new feature help wanted Not actively being worked on. If you plan to contribute, please drop a note. large effort Likely over a week of development effort merged Issue has been merged to dev and is waiting for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a security module （#628）
2 participants
@TomPallister @lfzm