#1375 #1237 #925 #920 Fix DownstreamRoute DangerousAcceptAnyServerCertificateValidator #1377
Conversation
raman-m
changed the title
|
Hi zhangq! Could you Sync fork please? So, your master branch was outdated! |
raman-m
added
bug
|
The feature branch has been rebased onto ThreeMammals:develop! |
raman-m
requested review from
binarymash,
jps,
geffzhang,
RaynaldM,
philproctor,
anktsrkr,
sharpn,
abooraja,
wast,
raman-m,
yangzhongke,
thiagoloureiro and
evgslyusar
and removed request for
evgslyusar
raman-m
changed the title
|
@RaynaldM Please, review, carefully! 😉 |
|
@RaynaldM Everything fine in testing? 😄 |
|
@raman-m When it's urgent, I just read the code and "judge" the form, and a little less the content. :) |
There was a problem hiding this comment.
The UseWebSocketsProxyMiddleware method enables custom WebSocketsProxyMiddleware in the pipeline.
But there is no usage of native WebSocketMiddleware class which is industry standard. But instead of standard framework middleware a custom WebSocketsProxyMiddleware class was written with custom Invoke method. This is design issue...
| using Ocelot.Logging; | ||
| using Ocelot.Middleware; | ||
| using System.Net.WebSockets; | ||
|
|
||
| namespace Ocelot.WebSockets.Middleware | ||
| namespace Ocelot.WebSockets | ||
| { | ||
| public class WebSocketsProxyMiddleware : OcelotMiddleware |
There was a problem hiding this comment.
- This class should be removed at all in favor of WebSocketMiddleware by Microsoft .NET team.
- This class should be redesigned based on WebSocketMiddleware by Microsoft .NET team.
raman-m
added
accepted
|
Related to #309 |
Fixes #1375 #1237 #925 #920