Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README #1499

Merged
merged 1 commit into from
Jun 4, 2023
Merged

Conversation

jusso-dev
Copy link
Contributor

Fixes

Proposed Changes

Added spacing between words in README.

@raman-m
Copy link
Member

raman-m commented Jun 3, 2023

Hi Justin!
I see commits which are not related to your changes!

Could you pull top-commits from develop branch please?
After that I'm asking you to rebase your feature branch plz!
If rebase operation failed with merge conflicts, it is better to create new feature branch and cherry pick your commit.
Good luck!

@raman-m raman-m force-pushed the jusso-dev/fix-readme branch from ad676e4 to 9933069 Compare June 3, 2023 17:23
@raman-m raman-m added the documentation Needs a documentation update label Jun 3, 2023
@raman-m raman-m self-requested a review June 3, 2023 17:27
@raman-m
Copy link
Member

raman-m commented Jun 3, 2023

Justin!
The rebase operation has succeeded!
Congrats!

@raman-m raman-m added the accepted Bug or feature would be accepted as a PR or is being worked on label Jun 3, 2023
@raman-m raman-m requested a review from TomPallister June 3, 2023 17:30
@TomPallister TomPallister merged commit 433dfca into ThreeMammals:develop Jun 4, 2023
@raman-m raman-m mentioned this pull request Jul 15, 2023
@raman-m raman-m added the merged Issue has been merged to dev and is waiting for the next release label Sep 6, 2023
raman-m added a commit that referenced this pull request Sep 19, 2023
* push code coverage for main and develop branches

* #1660 Huge logs because of StyleCop.Analyzers warnings (#1663)

* Add StyleCop.Analyzers package

* Fix SA0001: XML comment analysis is disabled due to project configuration

* Fix SA1609: Property documentation should have value

* Fix CS1591: Missing XML comment for publicly visible type or member {xyz}

* Fix SA1101: Prefix local calls with this

* Fix SA1413: The last statement in a multi-line C# initializer or list is missing a trailing comma.

* Fix SA1135: A using directive is not qualified.

* Fix compiler errors

* Fix SA1651: Do not use placeholder elements

* Fix compiling error

* Fix SA1113: Comma should be on the same line as previous parameter

* Fix SA1116: The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines

* Fix SA1137: Elements should have the same indentation

* Fix SA1200: Using directive should appear within a namespace declaration

* Fix SA1316: Tuple element names should use correct casing

* Fix SA1503: Braces should not be omitted

* Fix SA1505: An opening brace should not be followed by a blank line

* Fix SA1507: Code should not contain multiple blank lines in a row

* Fix SA1508: A closing brace should not be preceded by a blank line

* Fix SA1512, SA1515

* Fix SA1513: Closing brace should be followed by blank line

* Fix SA1400: Element 'OpenTracingTracer' should declare an access modifier

* Fix SA1515: Single-line comment should be preceded by blank line

* Fix SA1518: File is required to end with a single newline character

* Add StyleCop

* Fix SA1633: A C# code file is missing a standard file header.

* Disable SA1602: An item within a C# enumeration is missing an Xml documentation header.

* Fix SA1600: Elements should be documented

* Fix SA1604: Element documentation should have summary

* Fix SA1618: The documentation for type parameter 'T' is missing

* Fix SA1629: Documentation text should end with a period.

* Fix SA1649: File name should match first type name

* Fix SA1600: Elements should be documented

* Upgrade K8s sample to ASP.NET 7.
Rename project to Ocelot.Samples.OcelotKube.DownstreamService

* Upgrade K8s sample to ASP.NET 7.
Rename project to Ocelot.Samples.OcelotKube.ApiGateway

* Fix CS0169: The field 'xxx' is never used

* Fix CS0219: The variable 'baseUrl' is assigned but its value is never used

* Fix CS0414: The field 'xxx' is assigned but its value is never used

* Fix CS1570: XML comment has badly formed XML

* Fix CS0649: Field 'xxx' is never assigned to, and will always have its default value null

* Fix CS0618: 'member' is obsolete: 'text'

* Fix NU1504: Duplicate 'PackageReference' items found: Microsoft.Data.SQLite 7.0.4, Microsoft.Data.SQLite 7.0.5

* Upgrade sample to ASP.NET 7

* Fix NU5048: The 'PackageIconUrl'/'iconUrl' element is deprecated.
Consider using the 'PackageIcon'/'icon' element instead.
Learn more at https://aka.ms/deprecateIconUrl

* Rewrite a RequestDelegate object definition

* Fix CS0618: 'member' is obsolete: 'text'

* Fix CA1816: Change Dispose() to call GC.SuppressFinalize(object).
This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.

* Fix CA1822: Member 'GivenThereIsAConfiguration' does not access instance data and can be marked as static

* Fix CA1837: Use 'Environment.ProcessId' instead of 'Process.GetCurrentProcess().Id'

* Fix CA2211: Non-constant fields should not be visible.
Convert to property.

* Fix IDE0060: Remove unused parameter 'path' if it is not part of a shipped public API

* Fix CA1816: Change ConsulWebSocketTests.Dispose() to call GC.SuppressFinalize(object).

* Fix IDE1006: Naming rule violation: These words must begin with upper case characters

* Fix IDE1006: Naming rule violation: These words must begin with upper case characters: AcceptanceTests\WebSocketTests

* Fix last issues

* Upgrade basic sample to ASP.NET 7

* fixed up required spacing in README (#1499)

Co-authored-by: Justin Middler <[email protected]>

* Update README.md

---------

Co-authored-by: TomPallister <[email protected]>
Co-authored-by: Justin Middler <[email protected]>
Co-authored-by: Justin Middler <[email protected]>
Co-authored-by: Tom Pallister <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Bug or feature would be accepted as a PR or is being worked on documentation Needs a documentation update merged Issue has been merged to dev and is waiting for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants