-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore port when using UpstreamHost option #1505
Conversation
Cherry picked from ThreeMammals#1505
c31bbcb
to
a4a1e8b
Compare
Hi Kevin! What issue is this PR related to? |
@grssmnn I cannot get your proposal!.. You compare nginx & traefik but they are different networking tools than Ocelot. Could you describe your user scenario please? |
a4a1e8b
to
c3d0484
Compare
Specifying different ports for Upstream of routes will be completely different Ocelot's feature. Would you like to open new discussion as an issue? 😉 But your small fix cares about the hostname... |
src/Ocelot/DownstreamRouteFinder/Middleware/DownstreamRouteFinderMiddleware.cs
Outdated
Show resolved
Hide resolved
c3d0484
to
5b7e260
Compare
Fixes
I wanted to use the
UpstreamHost
option and found out that Ocelot is handling the port as part of the hostname (when running on a different port than :80/:443). For my understanding this is not the expected behaviour since any other software like nginx or traefik ignore the port when talking about the hostname.