Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor grammar fix in default rate limit response message #1639

Merged
merged 3 commits into from
Sep 22, 2023
Merged

fix: minor grammar fix in default rate limit response message #1639

merged 3 commits into from
Sep 22, 2023

Conversation

eddex
Copy link
Contributor

@eddex eddex commented Mar 13, 2023

Continue with upper-case letter after exclamation mark in default rate limit response message.

@raman-m raman-m self-requested a review May 5, 2023 11:07
raman-m
raman-m previously approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@raman-m raman-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another micro PR is approved! 😄

@raman-m raman-m force-pushed the fix/rate-limit-response branch from 8cd64b8 to c0cb37c Compare May 5, 2023 11:10
@raman-m raman-m requested a review from TomPallister May 5, 2023 11:16
@raman-m
Copy link
Member

raman-m commented May 5, 2023 •
edited
Loading

@TomPallister Hi Tom!
Merging is blocked! Even for such kind of tiny PRs. So, I have no right to merge being a member of Ocelot org. 😢
Could you auto-approve please? Builds are green.

@eddex
Copy link
Contributor Author

eddex commented May 5, 2023

Thanks for the review. Glad to see that there is still work being done on Ocelot! I was already a bit worried that the project might have been abandoned 😅

@raman-m raman-m added accepted Bug or feature would be accepted as a PR or is being worked on in progress Someone is working on the issue. Could be someone on the team or off. labels May 16, 2023
@raman-m raman-m removed the in progress Someone is working on the issue. Could be someone on the team or off. label Jun 3, 2023
@raman-m raman-m force-pushed the fix/rate-limit-response branch from c0cb37c to 414e9f4 Compare July 10, 2023 13:48
raman-m added a commit that referenced this pull request Jul 10, 2023
@raman-m
#1639 Update ClientRateLimitMiddleware.cs
996719e
@raman-m
Copy link
Member

raman-m commented Jul 10, 2023

Duplicate of #1678

@eddex Thank, you, Marco!

@raman-m raman-m closed this Jul 10, 2023
@eddex
Copy link
Contributor Author

eddex commented Jul 11, 2023

You copy my changes to your own (newly created) PR and close my PR as duplicate, taking full ownership of the changes I (and many other people) made for yourself. That's just rude.

@raman-m
Copy link
Member

raman-m commented Jul 11, 2023

eddex commented on Jul 11, 2023, 7:30 AM

With PR #1678 , all original commit authors were removed from the commits. This is very disrespectful to say the least..

eddex commented on Jul 11, 2023, 7:25 AM

You copy my changes to your own (newly created) PR and close my PR as duplicate, taking full ownership of the changes I (and many other people) made for yourself. That's just rude.

So sad to see such emotional reaction from you!

@raman-m raman-m reopened this Jul 11, 2023
@raman-m
Copy link
Member

raman-m commented Jul 11, 2023 •
edited
Loading

Dear Marco,

Sorry for closing your PR!
I am not going to explain you the reasons of creation of PR #1678: everything is explained/described in linked issue.
I've decided to reopen this PR for your own management.
If your current PR will be merged first I will remove the changes from my one. Deal?

You may ask Tom personally to merge this PR.
Good luck!

raman-m added a commit that referenced this pull request Jul 11, 2023
@raman-m
Revert "#1639 Update ClientRateLimitMiddleware.cs"
d4f3f7c 
This reverts commit 996719e.
@raman-m raman-m force-pushed the fix/rate-limit-response branch from 414e9f4 to b027c81 Compare September 19, 2023 08:22
@raman-m raman-m changed the base branch from develop to main September 19, 2023 08:26
@raman-m raman-m dismissed their stale review September 19, 2023 08:26

The base branch was changed.

@raman-m raman-m force-pushed the fix/rate-limit-response branch from b027c81 to b2ca8f8 Compare September 19, 2023 09:29
@raman-m raman-m self-requested a review September 19, 2023 09:32
raman-m
raman-m previously approved these changes Sep 19, 2023
View reviewed changes
@raman-m raman-m changed the base branch from main to develop September 20, 2023 13:26
@raman-m raman-m dismissed their stale review September 20, 2023 13:26

The base branch was changed.

@raman-m raman-m merged commit 8893f04 into ThreeMammals:develop Sep 22, 2023
raman-m added a commit that referenced this pull request Sep 23, 2023
@raman-m
Revert "#1639 Update ClientRateLimitMiddleware.cs"
565cb6b 
This reverts commit 996719e.
raman-m added a commit that referenced this pull request Sep 25, 2023
@raman-m
#1677 #1686 United documentation update (#1678)
75cd0b3 
* #1676 Update authorization.rst

* #1646 Update bigpicture.rst

* #1628 Update websockets.rst

* #1614 Update README.md

* #1552 Update configuration.rst

* #1547 Update caching.rst

* #1542 Update requestaggregation.rst

* Revert "#1639 Update ClientRateLimitMiddleware.cs"

This reverts commit 996719e.

* #1537 Update routing.rst

* #1520 Update authentication.rst

* #1459 Update building.rst

Fix inline code block

* #1412 Update errorcodes.rst

* #1407 Update headerstransformation.rst

* #1406 Update headerstransformation.rst

Remove extra '!'

* #1320 Update README.md

* Update README.md

Mark classes. Split sentences.

* #1284 Update claimstransformation.rst

* #1232 Update servicediscovery.rst

* #1224 Update loadbalancer.rst

* #1189 Update caching.rst

* Update gettingstarted.rst

Mark up 'net7.0' as code block. Convert script block to PowerShell one. Change the link to NuGet.

* #1386 Update loadbalancer.rst

* Update loadbalancer.rst: Make code snippet shorter

* #1686 Update middlewareinjection.rst

Add section "ASP.NET Core Middlewares and Ocelot Pipeline Builder"

* Update logging.rst

Review RST markup

* Update methodtransformation.rst

Review RST markup

* Update README.md

Sync to "Big Picture" page in Introduction
@raman-m raman-m mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MehdiSadeghi1996 MehdiSadeghi1996 MehdiSadeghi1996 approved these changes

@raman-m raman-m raman-m approved these changes

@TomPallister TomPallister Awaiting requested review from TomPallister

Assignees

@eddex eddex

Labels
accepted Bug or feature would be accepted as a PR or is being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddex @raman-m @MehdiSadeghi1996