Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the name of the DistributedCacheRateLimitCounterHandler class #1969

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

williamscs
Copy link
Contributor

Proposed Changes

This fixes a typo in a class name.

@raman-m
Copy link
Member

raman-m commented Feb 22, 2024

LoL 🤣 Thank you, Chris, for your eagle eye! 🦅

@raman-m
Copy link
Member

raman-m commented Feb 22, 2024

Have you ever heard about obfuscation technology? 😉 😆

@raman-m raman-m changed the title Fix typo in class name Fix typo in the name of the DistributedCacheRateLimitCounterHandler class Feb 22, 2024
@raman-m raman-m self-requested a review February 22, 2024 10:16
@raman-m raman-m added bug Identified as a potential bug accepted Bug or feature would be accepted as a PR or is being worked on documentation Needs a documentation update Jan'24 January 2024 release labels Feb 22, 2024
@raman-m raman-m added this to the January'24 milestone Feb 22, 2024
@raman-m
Copy link
Member

raman-m commented Feb 22, 2024

I can't get it... Why are there no references in DI? The class is defined, but not used in the solution... 🤯
Seems this is very old Tom's idea, and not finished feature...

@raman-m raman-m merged commit a9dff7c into ThreeMammals:develop Feb 22, 2024
2 checks passed
@raman-m raman-m added merged Issue has been merged to dev and is waiting for the next release and removed accepted Bug or feature would be accepted as a PR or is being worked on labels Feb 22, 2024
@williamscs
Copy link
Contributor Author

I can't get it... Why are there no references in DI? The class is defined, but not used in the solution... 🤯 Seems this is very old Tom's idea, and not finished feature...

I only found it because of this issue: #609

I believe the intent is that it isn't used within the repo (though maybe it needs tests). I think you're supposed to instantiate yourself it in order to support rate limiting across multiple replicas. I was going to test it out this week or next.

@raman-m
Copy link
Member

raman-m commented Feb 22, 2024

OK Do you use Redis Cache or something else?

@raman-m raman-m mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identified as a potential bug documentation Needs a documentation update Jan'24 January 2024 release merged Issue has been merged to dev and is waiting for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants