-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1844 More open customization of Polly use #1974
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Raman Maksimchuk <[email protected]>
Co-authored-by: Raman Maksimchuk <[email protected]>
…ithub.com/ThreeMammals/Ocelot into 1844-more-open-customization-of-polly-use
RaynaldM
added
feature
A new feature
small effort
Likely less than a day of development effort.
Jan'24
January 2024 release
labels
Feb 26, 2024
raman-m
approved these changes
Feb 26, 2024
@RaynaldM Please merge by Squash and merge option only ❗ ❗ ❗ |
raman-m
changed the title
1844 more open customization of polly use
#1844 More open customization of Polly use
Feb 26, 2024
Congrats! 🥳 And we don't need this branch anymore... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
A new feature
Jan'24
January 2024 release
small effort
Likely less than a day of development effort.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain contexts, we need to be able to fully tune the way Polly is used for timeouts and circuit-breakers, but not only that.
With this in mind, I'm proposing in this PR to open up the use of AddPolly by adding :
Thanks to this, we will be able to use our own implementations of
IPollyQoSProvider<HttpResponseMessage>
,QosDelegatingHandlerDelegate
andDictionary<Type, Func<Exception, Error>>