Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File-scoped namespaces everywhere #2211

Merged
merged 10 commits into from
Nov 22, 2024
Merged

Conversation

raman-m
Copy link
Member

@raman-m raman-m commented Nov 21, 2024

The File-scoped namespace feature was introduced in C# 10, also known as .NET 5 however, most of our source files still utilize block-scoped namespace definitions.

Proposed Changes

  • ensure consistency across all files
  • To minimize "fake" changes in pull requests; PRs will allow a focus on real changes in the diff
  • Finally, the Blame operation will be more effective on GitHub, it currently functions correctly in Visual Studio
  • This is a required step to upgrade the solution to .NET 9

@raman-m raman-m requested review from RaynaldM and ggnaegi November 21, 2024 18:07
@raman-m raman-m self-assigned this Nov 21, 2024
@raman-m raman-m added Core Ocelot Core related or system upgrade (not a public feature) Dec'24 December 2024 release labels Nov 21, 2024
@raman-m raman-m added this to the Autumn'24 milestone Nov 21, 2024
@raman-m raman-m added the high High priority label Nov 21, 2024
Copy link
Member

@ggnaegi ggnaegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now let's prepare the .NET 9 migration!

@raman-m raman-m merged commit da5431b into develop Nov 22, 2024
1 check passed
@raman-m raman-m deleted the raman-m/file-scoped-namespaces branch November 22, 2024 07:37
raman-m added a commit that referenced this pull request Nov 22, 2024
* Convert to file-scoped namespace: Ocelot

* Convert to file-scoped namespace: Ocelot.Administration

* Convert to file-scoped namespace: Ocelot.Cache.CacheManager

* Convert to file-scoped namespace: Ocelot.Provider.Kubernetes

* Convert to file-scoped namespace: Ocelot.AcceptanceTests

* Convert to file-scoped namespace: Ocelot.Benchmarks

* Convert to file-scoped namespace: Ocelot.UnitTests

* Convert to file-scoped namespace: Ocelot.IntegrationTests

* Convert to file-scoped namespace: Ocelot.Samples

* Fix namespaces in sample projects
@raman-m
Copy link
Member Author

raman-m commented Nov 22, 2024

New commit in develop is e9a8bfc

@raman-m raman-m added Nov'24 November 2024 release and removed Dec'24 December 2024 release labels Nov 22, 2024
@raman-m raman-m modified the milestones: Autumn'24, November'24 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Ocelot Core related or system upgrade (not a public feature) high High priority Nov'24 November 2024 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants