[pull] master from xbmc:master #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
To solve compiling errors it was necessary to update all library versions and the compileSdk to the latest version. Also removed: - butterknife rules from proguard-rules - nonFinalResIds directive as non final R resources were fixed in #838
Following #980, and for consistency, this also applies the back navigation to pinned addons directories.
Updating the minSdk version allows use of more Java 8 language features (without desugaring need) and the removalof code that dealt with older versions. Given that api level 24 (Android 7) come out in 2016 and usage of Android versions 5 and 6 (Api levels 21, 22, 23) are bellow 1% and decreasing (as reported by Google Play), this seems an appropriate tradeoff.
- Add notification permission to manifest, though it is not strickly needed as all notifications are attached to a MediaSession and those are exempt from Android's 13 new requirements on notification permissions https://developer.android.com/develop/ui/views/notifications/notification-permission - Use granular media permissions, switching from READ_EXTERNAL_STORAGE to READ_MEDIA_{IMAGES|VIDEO|AUDIO} https://developer.android.com/about/versions/13/behavior-changes-13#granular-media-permissions
- Specify foreground service type, namely on the MediaSessionService - Regarding changes to granting partial access to photos and videos, nothing was changed, so it relies on compatibility mode. [More here](https://developer.android.com/about/versions/14/changes/partial-photo-video-access) The default compatibility mode works more or less ok, and adding specific logic to handle partial access wouldn't help much and would confuse the code.
This message is extremely important for new users, and was a bit light on details. This improves it with more detailed information on how to connect to Kodi
Instead of relying on a separate step for signing, this make Gradle sign the release apk Requires that the following environment variables are set: - KODI_ANDROID_STORE_FILE - KODI_ANDROID_STORE_PASSWORD - KODI_ANDROID_KEY_ALIAS - KODI_ANDROID_KEY_PASSWORD Also changed the jenkins scripts to exclude the signing step and get the correct apk to be moved to the mirrors
The previous PR tried to move the wrong file, this fixes it
* [gradle] signing * [jenkins] remove apksign script No longer needed due to signing with gradle --------- Co-authored-by: fuzzard <[email protected]>
Namely the okhttp library, to possibly fix errors reported on Google Play
The message will be seen by the user, so it should be clear. Ideally it shouldn't be done this way, as it can't be translated because there's no context to get the translated string, but it's what possible for now.
* Add setting for the preferred YouTube add-on (#978) * Move creation of YouTube plugin URL to a dedicated method (#978) This makes it easier to extend the functionality and incorporate other add-ons for YouTube. * Create a dedicated method for the default YouTube add-on (#978) * Add support for the Invidious add-on for YouTube (#978)
Move code from ShareOpenActivity to PluginUtlUtils to keep all code dealing with Plugin URL translation in the same place Tweak preferences screen to show Addon settings in a more logical place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )