[PLATFORM-3432] Update fork with upstream (v1.1.3) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoginSync-Payload
aflesher
approved these changes
Jul 17, 2024
| "build": "rimraf dist && tsc -p tsconfig.prod.json", | ||
| "release": "npm run build && ./scripts/release.sh", | ||
| "playwright": "npm run build && docker-compose -f docker-compose.playwright.yml up --build -d && cd playwright && playwright test && docker-compose -f ../docker-compose.playwright.yml down", | ||
| "playwright": "npm run build && docker compose -f docker-compose.playwright.yml up --build -d && cd playwright && playwright test && docker compose -f ../docker-compose.playwright.yml down", |
There was a problem hiding this comment.
Is this a recent change to docker? I've always used docker-compose
There was a problem hiding this comment.
| as --> sdk: {error=access_denied} | ||
| deactivate as | ||
| deactivate sdk | ||
| @enduml |
There was a problem hiding this comment.
Great to see this plantuml diagrams added to the source. Not a blocker but we should add an image of the rendered diagrams to the source like our other repos.
Evanjt1
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLATFORM-3432
Latest version of upstream (v1.1.3) has some updates to the login sync api that we'll need for some upcoming features. This PR brings our fork up to current head of upstream.