-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CocoaPods spec file is out of date #83
Comments
I don't have rights to update Pod. Now you can use my up-to-date version of ActionSheetPicker (ActionSheetPicker-3.0) |
Evernote was unable to submit your note for the following reason: The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered. Original message information: To prevent excessive emails, you may not receive another error reply for the next 360 minutes.
|
@skywinder It looks like you have since managed to update the pod spec, should we now be using this repository? Will the two repositories stay in sync, or will the 3.0 version be ahead? Or are you planning on dropping your ActionSheetPicker-3.0 fork? Thanks |
Evernote was unable to submit your note for the following reason: The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered. Original message information: To prevent excessive emails, you may not receive another error reply for the next 360 minutes.
|
Hi, @Jack-s. |
@skywinder OK thanks, what about opening issues if I encounter one that exists in this repository should I assume you are aware of it (so as to avoid duplication)? For example the current version doesn't work on the iOS 8 Beta, I haven't tried the 3.0 version but I'm assuming it has the same problem. |
Evernote was unable to submit your note for the following reason: The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered. Original message information: To prevent excessive emails, you may not receive another error reply for the next 360 minutes.
|
@Jack-s Good question. Due all respect to great work of Tim, this implementation has a lot of outdated code with a lot of strange "magic numbers", hacks, e.t.c., that appeared with new versions of iOS (4->5->6->7).. (and, I'm sure, thats why it not working on iOS 8). In my version I want to make the same functionality from scratch. I start my repo, when this repo seems like a not living for a year. Sorry for this confusion. |
@Jack-s Anyway, it easier to create cross-references to issues and pull requests like this: |
@skywinder Thanks for clarifying. One modification that I made locally (I think this was before the pod spec was added) was to add a MinuteInterval Option for the date picker, I see there already is a pull request by detouch to add that but it hasn't been merged (probably because it has some conflicts). Should I create a new pull request just to add that? It seems a little bit overkill to since essentially all that is needed is to add a property to
And then in
Thanks |
Evernote was unable to submit your note for the following reason: The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered. Original message information: To prevent excessive emails, you may not receive another error reply for the next 360 minutes.
|
@Jack-s Yes, you can add minuteInterval in separate pull request. I will be pleased to merge it! |
The CocoaPod spec in https://github.com/CocoaPods/Specs/blob/master/ActionSheetPicker/0.0.1/ActionSheetPicker.podspec is linked to a commit from March 21, 2012 5:32 PM.
The repo should be tagged with version numbers and pointed to the latest commit.
The text was updated successfully, but these errors were encountered: