Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPods spec file is out of date #83

Closed
rhfung opened this issue May 22, 2013 · 8 comments
Closed

CocoaPods spec file is out of date #83

rhfung opened this issue May 22, 2013 · 8 comments

Comments

@rhfung
Copy link

rhfung commented May 22, 2013

The CocoaPod spec in https://github.com/CocoaPods/Specs/blob/master/ActionSheetPicker/0.0.1/ActionSheetPicker.podspec is linked to a commit from March 21, 2012 5:32 PM.

The repo should be tagged with version numbers and pointed to the latest commit.

@skywinder
Copy link
Collaborator

I don't have rights to update Pod.
(Because owner of this Pod not me, even not Tim, - TheEskil (https://github.com/TheEskil/)
I send him a pull request and I hope he update this pod soon.

Now you can use my up-to-date version of ActionSheetPicker (ActionSheetPicker-3.0)
pod 'ActionSheetPicker-3.0', '~> 1.0.3'
Now it exactly the same as master branch of TimCinel's branch.
I'll let you know, when this branch will be able to update to last version.

@ma2kubo
Copy link

ma2kubo commented May 26, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <[email protected]>
Delivered To: [email protected]
All recipients: TimCinel/ActionSheetPicker <[email protected]>
Subject: Re: [ActionSheetPicker] CocoaPods spec file is out of date (#83)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@Jack-s
Copy link

Jack-s commented Jun 23, 2014

@skywinder It looks like you have since managed to update the pod spec, should we now be using this repository? Will the two repositories stay in sync, or will the 3.0 version be ahead? Or are you planning on dropping your ActionSheetPicker-3.0 fork? Thanks

@ma2kubo
Copy link

ma2kubo commented Jun 23, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Jack <[email protected]>
Delivered To: [email protected]
All recipients: TimCinel/ActionSheetPicker <[email protected]>; ma2kubo <[email protected]>
Subject: Re: [ActionSheetPicker] CocoaPods spec file is out of date (#83)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

Hi, @Jack-s.
Yes, now I manage both of this specs.
So, in this repo I just want to resolve many of pull requests, that accumulated here for last year and make it stable on iOS 7 and above.
Now they are synced, but in future I'm going to improve just my version.
So, if you would like to have up-to-date version - it's better to use ActionSheetPicker-3.0.

@Jack-s
Copy link

Jack-s commented Jun 23, 2014

@skywinder OK thanks, what about opening issues if I encounter one that exists in this repository should I assume you are aware of it (so as to avoid duplication)? For example the current version doesn't work on the iOS 8 Beta, I haven't tried the 3.0 version but I'm assuming it has the same problem.

@ma2kubo
Copy link

ma2kubo commented Jun 23, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <[email protected]>
Delivered To: [email protected]
All recipients: TimCinel/ActionSheetPicker <[email protected]>; ma2kubo <[email protected]>
Subject: Re: [ActionSheetPicker] CocoaPods spec file is out of date (#83)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

@Jack-s Good question.

Due all respect to great work of Tim, this implementation has a lot of outdated code with a lot of strange "magic numbers", hacks, e.t.c., that appeared with new versions of iOS (4->5->6->7).. (and, I'm sure, thats why it not working on iOS 8).

In my version I want to make the same functionality from scratch.
That's why I want to split these 2 repos.

I start my repo, when this repo seems like a not living for a year.
Since I'm collaborator of this repo and able to manage it - I think it's better to put all issues, that related to this version here, to have all entirety all of them.

Sorry for this confusion.

@skywinder
Copy link
Collaborator

@Jack-s
I decide to do close old pull requests and issues in this repo.
But new fixes and features will be available in https://github.com/skywinder/ActionSheetPicker-3.0

Anyway, it easier to create cross-references to issues and pull requests like this:
skywinder#5 and duplicate #113 and Pull request: skywinder#6

@Jack-s
Copy link

Jack-s commented Jul 9, 2014

@skywinder Thanks for clarifying. One modification that I made locally (I think this was before the pod spec was added) was to add a MinuteInterval Option for the date picker, I see there already is a pull request by detouch to add that but it hasn't been merged (probably because it has some conflicts).

Should I create a new pull request just to add that? It seems a little bit overkill to since essentially all that is needed is to add a property to ActionSheetDatePicker.h like the following

@property (nonatomic) NSInteger minuteInterval;

And then in initWithTitle:datePickerMode:selectedDate:action:origin assign it

self.minuteInterval = 1;

Thanks

@ma2kubo
Copy link

ma2kubo commented Jul 9, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Jack <[email protected]>
Delivered To: [email protected]
All recipients: TimCinel/ActionSheetPicker <[email protected]>; ma2kubo <[email protected]>
Subject: Re: [ActionSheetPicker] CocoaPods spec file is out of date (#83)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

@Jack-s Yes, you can add minuteInterval in separate pull request. I will be pleased to merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants