Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow action sheet tile specification, remove duplicate files #5

Merged
merged 2 commits into from
May 11, 2011

Conversation

brettg
Copy link
Contributor

@brettg brettg commented May 10, 2011

I found to it useful to be able to specify the title of the action sheet, so I thought I might as well create a pull request in case you're interested. Also included (in a separate commit) is a change that uses a project relative references to the main ActionSheetPicker.{h,m} files in the demo app instead of having those files duplicated.

Thanks for sharing this.

@TimCinel TimCinel merged commit d95df2c into TimCinel:master May 11, 2011
@TimCinel
Copy link
Owner

Thanks for sharing your changes! An earlier commit which hadn't yet been merged added the title functionality, so I didn't merge your title-related changes. However, I did merge the relative reference changes - much better.

I've added you to the README as a contributor :)

Regards,
Tim Cinel

On 11/05/2011, at 4:49, [email protected] wrote:

I found to it useful to be able to specify the title of the action sheet, so I thought I might as well create a pull request in case you're interested. Also included (in a separate commit) is a change that uses a project relative references to the main ActionSheetPicker.{h,m} files in the demo app instead of having those files duplicated.

Thanks for sharing this.

Reply to this email directly or view it on GitHub:
https://github.com/sickanimations/ActionSheetPicker/pull/5

skywinder referenced this pull request in skywinder/ActionSheetPicker-3.0 May 16, 2014
Added popoverBackgroundViewClass property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants