Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customise Maximum and Minimum Date of UIDatePicker #96

Merged
merged 1 commit into from
May 29, 2014

Conversation

ronakjangir47
Copy link
Contributor

No description provided.

@ma2kubo
Copy link

ma2kubo commented Feb 11, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Ronak Jangir <[email protected]>
Delivered To: [email protected]
All recipients: TimCinel/ActionSheetPicker <[email protected]>
Subject: [ActionSheetPicker] Allow to customise Maximum and Minimum Date of UIDatePicker (#96)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

Ok!
It's better to cover new features with tests.
Since it can make side effects.
It's better to test default cases, such as nil and some default values for new properties.
I'll try to cover by tests this project. May be this case too.
After that I'll glad to merge this pull request.

@ma2kubo
Copy link

ma2kubo commented May 26, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <[email protected]>
Delivered To: [email protected]
All recipients: TimCinel/ActionSheetPicker <[email protected]>; ma2kubo <[email protected]>
Subject: Re: [ActionSheetPicker] Allow to customise Maximum and Minimum Date of UIDatePicker (#96)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder skywinder mentioned this pull request May 26, 2014
skywinder added a commit that referenced this pull request May 29, 2014
Allow to customise Maximum and Minimum Date of UIDatePicker
@skywinder skywinder merged commit 6a17f83 into TimCinel:master May 29, 2014
@skywinder
Copy link
Collaborator

Ok, I check it. Since all of this values nil by default you can set it. Without any side effects.
Thank you. 👍

jum pushed a commit to jum/ActionSheetPicker that referenced this pull request Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants