Skip to content

Commit

Permalink
Update validation comments
Browse files Browse the repository at this point in the history
  • Loading branch information
TimRudy committed Aug 31, 2020
1 parent c31ce99 commit d9b76ea
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
5 changes: 3 additions & 2 deletions scripts/validate/check-index-contents.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ class IndexFileDeviceFilesHelper {
}
}

console.log('Passed');
return 'Passed';
console.log('Passed: Index contents');
return 'Passed: Index contents';
}
}

Expand All @@ -98,6 +98,7 @@ deviceFilePathList = walkSync(fsHelper.getBasePathFromDirectoryPath(baseDirector
],
ignore: [
'**/*-tb.v',
'docs/**',
'images/**',
'includes/**',
'scripts/**'
Expand Down
5 changes: 3 additions & 2 deletions scripts/validate/exec-verilog.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// exec-verilog.js
//
// - validate every IC device '*.v' by running it through its test bench '*-tb.v'
// - validate every IC device '*.v' by running it through its test bench '*-tb.v', and
// enforce that there is a test bench for every device
//
// - argument (optional): top level directory of the project
//
Expand Down Expand Up @@ -42,7 +43,7 @@ class VerilogTestBenchHelper {
throw 'No test bench file: ' + testBenchFilePath;
}

// collect the logged output from executing iverilog and vvp externally
// collect the logged output from executing command line iverilog and vvp
deviceTestOutput = this.execDeviceTests(testBenchFilePath,
deviceFilePath,
includesDirectoryPath,
Expand Down
2 changes: 1 addition & 1 deletion scripts/validate/fs-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class FsHelper {
targetDirectory = defaultDirectory + targetDirectory;
}

// put in canonical form of a directory (acts as a prefix)
// put in canonical form of a directory (it will act as a prefix)
if (!(targetDirectory.endsWith('/') || targetDirectory.endsWith('\\'))) {
targetDirectory = targetDirectory + '/';
}
Expand Down

0 comments on commit d9b76ea

Please sign in to comment.