Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add .git-blame-ignore-revs #249

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Oct 23, 2024

Make git blame to ignore certain commits. 71bec22 is the commit reformatting all kotlin code.

Note that this won't just work magically and requires $ git config blame.ignoreRevsFile .git-blame-ignore-revs.

Feel free to close this PR if it feels rather unnecessary.

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tinder-maxwellelliott
❌ honnix
You have signed the CLA already but the status is still pending? Let us recheck it.

@honnix
Copy link
Contributor Author

honnix commented Oct 23, 2024

I think build no longer works for forks:

ERROR: The Build Event Protocol upload failed: Not retrying publishBuildEvents, no more attempts left: status='Status{code=UNAUTHENTICATED, description=failed to parse API key: missing API Key, cause=null}' UNAUTHENTICATED: UNAUTHENTICATED: failed to parse API key: missing API Key UNAUTHENTICATED: UNAUTHENTICATED: failed to parse API key: missing API Key

@tinder-maxwellelliott
Copy link
Collaborator

Ill land this first #250 , need to find another way to make that work with PRs

@honnix
Copy link
Contributor Author

honnix commented Oct 23, 2024

Ill land this first #250 , need to find another way to make that work with PRs

I see some repos requiring approval to run CI pipelines. Maybe that helps with this. I have not used any of those myself.

@tinder-maxwellelliott tinder-maxwellelliott merged commit 4610cc6 into Tinder:master Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants