Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for recipe_cubit #365

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Add testing for recipe_cubit #365

merged 2 commits into from
Jan 29, 2024

Conversation

beatbrot
Copy link
Contributor

I did some manual dependency injection for the transaction handler. Please give feedback :)

@TomBursch
Copy link
Owner

Awesome, this looks great!

I did some manual dependency injection for the transaction handler.

This is good for now, in the future, I want to get rid of the transaction handler's singleton pattern and use RepositoryProvider to supply it to the cubits or use reactive repositories. Which hopefully makes testing widgets easier, too.

I'll merge this after I'm done with #356

@TomBursch TomBursch added the enhancement New feature or request label Jan 15, 2024
@TomBursch TomBursch merged commit bc5003c into TomBursch:main Jan 29, 2024
2 checks passed
@beatbrot beatbrot deleted the recipe_cubit_testing branch January 29, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants