fix: use DOM base href for web XHRs #565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
html.document.baseUri.toString()
as base URL for the web-app, the base tag in the DOM is considered correctly.This allows serving the application from a sub-directory (e.g. https://foo.com/kitchenowl/).
Tested with and without subdir-serving.
Future todo's: Replace DOM
<base href="...">
with environment variable content etc. for easy containerized deployment.Partial implementation for #130, #237