-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Real-time sync shopping lists addition/removal #578
Feat: Real-time sync shopping lists addition/removal #578
Conversation
Yeah, that's fine. Also, thanks for the refactor. I know this is a draft, but in general, I'd recommend branching from main, since this PR doesn't really depend on the other changes. This saves you some time when changes have to be made in other PRs (and you won't need to update this branch because of that) and makes it a bit easier to review, and we could have merged this already 😉 |
Yeah, at first glance it does not depend but on my dev side it does because of the changes on the launch.json (which keeps giving me git errors when changing branches due to being overwritten on the checkout of the other branches). Maybe I'll just be more patient in the future with opening these PRs. |
962bd71
to
774c1bb
Compare
Looks good, I noticed the |
I didn't add them as nobody uses them. So there would be less API to test later. |
They are used inside the close method of the cubit.
If you switch households, for example, the cubit is closed but would remain a listener on the socket events. This would result in errors and a memory leak, since it couldn't be garbage collected. |
7d0298a
to
c65c559
Compare
Adding or removing shopping lists now immediately updates them in the available shopping list selector in the "add items" overview.
c65c559
to
3015952
Compare
Add real-time synchronization to shopping lists
Adding or removing shopping lists now immediately
updates them in the available shopping list selector
in the "add items" overview.
I'm not entirely sure if calling
refresh()
is enough. At least in my tests it was but I'm not sure if there are side-effects missing that I don't know about.When you use the Linux or Android App and have Chrome open at the same time the update in Chrome happens once the window has focus. Not sure what that is about.
Again this PR is only a draft as it depends on other PRs. I'll rebase onto main once those are complete.