fix: prevent incorrect offline->online transitions without successful… #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irishrain
force-pushed
the
fix/offline-mode-race-condition
branch
from
4ab9571 to
d9f3402
Compare
|
Is this superseded now by #610? I noticed that you fixed that there too in a slightly different way. |
|
Oh no, I must have somehow messed up with git branches. |
irishrain
force-pushed
the
fix/offline-mode-race-condition
branch
from
d9f3402 to
83b10ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #610 I found a race condition that sometimes logs the user out when coming out of offline mode when the network is bad. #610 and this should fix #414 for good.