Store credit cancel #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmacdougall
force-pushed
the
store-credit-cancel
branch
from
beb3b0d to
3de4145
Compare
|
When I cancel an order with captured store payments, I see my store credit payment is voided, but when I view the ledger history, I see no originator for the reversing entry. |
This is a payment method, if it returns a boolean then spree/payment/processing.rb will blow up. We are seeing this happen when captured store credits are refunded and the handle_void_response method tries to check the response.success? Although I have not added a test for the last code path, I think we can refactor it away when we're done with our changes.
This will not attempt to credit store credit for zero dollar amount, which will trigger errors.
Previously there was some unsafe math where numbers were multiplied and divided by 100 in the store credit section. This is a step towards getting rid of that.
gmacdougall
force-pushed
the
store-credit-cancel
branch
from
3de4145 to
fc86cfa
Compare
|
I added the originator in to that such that it gets sent in to the ledger. |
|
When I complete an order using only store credit, refund the full amount of the store credit and then cancel the order I get this error: https://app.bugsnag.com/tommy-john-inc/tommyjohn-dot-com/errors/5835a32107b7add195afef27?filters%5Bevent.since%5D%5B%5D=30d&filters%5Berror.status%5D%5B%5D=open |
When a payment is cancelled, previously it would attempt to return the whole amount to the store credit even if it had been entirely or partially refunded. Conflicts: core/app/models/spree/payment_method/store_credit.rb core/spec/models/spree/payment_method/store_credit_spec.rb
gmacdougall
force-pushed
the
store-credit-cancel
branch
from
fc86cfa to
af21dd1
Compare
|
I have updated this to correctly work when the full amount is already refunded. |
stewart
approved these changes
Nov 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve store credit cancellation
This brings in two PR's from Solidus which improve the flow of cancelling orders with store credit payments:
solidusio#1292
solidusio#1603