Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Projection Operator from SPDHG tests #2026

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Jan 7, 2025

Description

The Projection Operator in the SPDHG tests required astra to be installed. However, the projection operator was only being used to produce some example data, it wasn't actually used in the tests. I have removed this and am using some CIL example data instead.

Related issues/links

Closes #2025

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff MargaretDuff linked an issue Jan 7, 2025 that may be closed by this pull request
@MargaretDuff MargaretDuff requested a review from gfardell January 7, 2025 11:29
@MargaretDuff MargaretDuff self-assigned this Jan 7, 2025
@MargaretDuff MargaretDuff added bug Something isn't working Waiting for review labels Jan 7, 2025
@MargaretDuff MargaretDuff merged commit c79eda4 into master Jan 8, 2025
10 checks passed
@MargaretDuff MargaretDuff deleted the spdhg-tests-without-astra branch January 8, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Waiting for review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SPDHG tests running in an environment without astra
3 participants