Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation tests to CI #1082

Closed
aaronmondal opened this issue Jul 5, 2024 · 2 comments · Fixed by #1268
Closed

Add documentation tests to CI #1082

aaronmondal opened this issue Jul 5, 2024 · 2 comments · Fixed by #1268
Assignees
@aaronmondal @Evaan2001
Labels
bug Something isn't working

Comments

@aaronmondal
Copy link
Member

To prevent issues like #1081 in the future.

While it's a bit tedious to create entire deployment pipelines, we should have at least run doc builds as a CI test. Preview builds already run the Typescript linting infrastructure and invoke the generator scripts on all inputs used which should cover a reasonably large surface area of potential issues.
@aaronmondal aaronmondal added the bug Something isn't working label Jul 5, 2024
@aaronmondal aaronmondal self-assigned this Jul 5, 2024
@aaronmondal aaronmondal changed the title Ad documentation tests to CI Add documentation tests to CI Jul 5, 2024
@Evaan2001
Copy link

I'm working on this issue right now; PR should hopefully be up tomorrow, July 28th.

@Evaan2001 Evaan2001 mentioned this issue Jul 30, 2024
Closed
1 task
@Evaan2001
Copy link

Evaan2001 commented Jul 30, 2024 •
edited
Loading

Pull request is up – github.com//pull/1217. I'm failing a CI test. I edited the run_integration_tests.sh script and one of my comments seems to cause the failure. As this is my first time editing a CI pipeline, some feedback/direction would be great!

Edit – It's not a comment that's causing a failure (my bad on misinterpreting GitHub Actions) but the fact that I'm running "docs builds". Shifting this conversation to the PR page.

Evaan2001 added a commit to Evaan2001/nativelink that referenced this issue Jul 30, 2024
@Evaan2001
Add "docs builds" Into CI Tests
9d4ac5c 
This commit tackles Issue TraceMachina#1082. It runs the command "docs builds" in run_integration_tests.sh, a script executed by main.yaml during CI. This addition should ensure that "docs builds" always runs before merging a PR.
@Evaan2001 Evaan2001 mentioned this issue Jul 30, 2024
Closed
1 task
@aaronmondal aaronmondal mentioned this issue Aug 21, 2024
Merged
6 tasks
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Aug 23, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
1cdb916 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Aug 23, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
a7afde8 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Aug 23, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
4e847c7 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Aug 24, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
c2f7222 
Fixes TraceMachina#1082
aaronmondal pushed a commit to aaronmondal/nativelink that referenced this issue Aug 24, 2024
@SchahinRohani @aaronmondal
Migrate docs buildsystem from pnpm to bun
33c2b40 
Fixes TraceMachina#1082
aaronmondal pushed a commit to aaronmondal/nativelink that referenced this issue Aug 29, 2024
@SchahinRohani @aaronmondal
Migrate docs buildsystem from pnpm to bun
0e19f01 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Sep 3, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
e8ebe88 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Sep 3, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
6853342 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Sep 3, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
ed42623 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Sep 3, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
e8df36b 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Sep 3, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
a73bc53 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Sep 3, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
8a42067 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Sep 3, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
413ee69 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Sep 3, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
07252b5 
Fixes TraceMachina#1082
SchahinRohani added a commit to SchahinRohani/nativelink that referenced this issue Sep 3, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun
e6a428e 
Fixes TraceMachina#1082
aaronmondal pushed a commit that referenced this issue Sep 4, 2024
@SchahinRohani
Migrate docs buildsystem from pnpm to bun (#1268)
ef3a8a6 
Fixes #1082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronmondal aaronmondal

@Evaan2001 Evaan2001

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate docs build system from pnpm to bun SchahinRohani/nativelink
2 participants
@aaronmondal @Evaan2001