Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release NativeLink v0.5.0 #1223

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Jul 30, 2024

This change is Reviewable

@aaronmondal
Copy link
Member Author

(needs changelog cleanup)

Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 15 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and 14 of 15 files reviewed, and pending CI: Cargo Dev / macos-13, Installation / macos-13, Installation / macos-14, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04

Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 15 files at r1.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Cargo Dev / macos-13, Installation / macos-13, Installation / macos-14, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 15 files at r1, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and pending CI: Remote / large-ubuntu-22.04

@aaronmondal
Copy link
Member Author

@aaronmondal aaronmondal marked this pull request as ready for review August 7, 2024 00:46
@MarcusSorealheis
Copy link
Collaborator

Reviewable is frequently down.

Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 15 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 LGTMs obtained, and all files reviewed

@aaronmondal aaronmondal force-pushed the release-0.5.0 branch 3 times, most recently from b12a58a to 8b2eb2d Compare August 7, 2024 14:05
Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and pending CI: Remote / large-ubuntu-22.04

@aaronmondal aaronmondal merged commit d898c54 into TraceMachina:main Aug 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants