Fix nix2container skopeo patch hash #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change in GitHub's hashing scheme caused this to evaluate differently. Add a temporary override to nix2container to unbreak CI.
aaronmondal
changed the title
8 tasks
bclark8923
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Is this to fix the lre.yaml large-ubuntu test? May want to remove the if: false so it runs that test on your PR
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 2 files reviewed, and pending CI: Installation / macos-13
caass
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained, and all files reviewed
aaronmondal
added a commit
that referenced
this pull request
Aug 30, 2024
This reverts commit 689d099.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in GitHub's hashing scheme caused this to evaluate differently. Add a temporary override to nix2container to unbreak CI.
This change is