Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web workflow #1370

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Update web workflow #1370

merged 1 commit into from
Sep 27, 2024

Conversation

SchahinRohani
Copy link
Contributor

@SchahinRohani SchahinRohani commented Sep 27, 2024 •
edited by allada
Loading

Description

Remove the resend env variable from deno deploy and unify the linux and macos build step

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

SchahinRohani
SchahinRohani commented Sep 27, 2024
View reviewed changes
Copy link
Contributor Author

@SchahinRohani SchahinRohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@aaronmondal

Reviewable status: 0 of 1 LGTMs obtained, and 0 of 1 files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache (LRE), Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable (waiting on @aaronmondal)

aaronmondal
aaronmondal approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache (LRE), Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable

@SchahinRohani
Fix web workflow
97d6254 
Remove the env variable from deno deploy and unify the linux and macos build step
@SchahinRohani SchahinRohani changed the title Fix web workflow Update web workflow Sep 27, 2024
aaronmondal
aaronmondal approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained, and all files reviewed

@SchahinRohani SchahinRohani merged commit 68753c6 into TraceMachina:main Sep 27, 2024
32 checks passed
@SchahinRohani SchahinRohani deleted the fix/web-workflow branch September 27, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmondal aaronmondal aaronmondal approved these changes

Assignees

@aaronmondal aaronmondal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SchahinRohani @aaronmondal