Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macos-build-script.sh #71

Merged
merged 19 commits into from
Apr 8, 2024
Merged

Conversation

hyrulelinks
Copy link
Contributor

@hyrulelinks hyrulelinks commented Mar 10, 2024

  • Change realesrgan-ncnn-vulkan to upscayl-ncnn, the latter is a continued development project of the former
  • The script will auto download the latest executable program of upsample-ncnn and the model of realsr-ncnn-vulkan from the project release. realesrgan-ncnn-vulkan is still the outdated Sep 2022 version that has not been maintained for a long time
  • Add RealSR model to provide higher super-resolution fidelity for real photos
  • Eliminate the 2x and 3x versions of Real-ESRGAN's animevideov3 due to their inadequate upscaling capabilities and tendency to generate flawed images
  • Modify the script content for downloading the Super Resolution executable program and models
  • The script has been tested successfully on the M1 Max Macbook Pro
    @TransparentLC

- Change realesrgan-ncnn-vulkan to upscayl-ncnn, the latter is a continued development project of the former
- Increase the RealSR model, which provides better super-resolution fidelity for real photos
- Remove the 2x and 3x models of Real-ESRGAN's animevideov3 due to their poor upscaling performance and tendency to produce erroneous images
- Modify the script content for downloading the Super Resolution executable program and models
@TransparentLC
Copy link
Owner

I hadn't realized that Real-ESRGAN still has actively maintained forks, thanks!

I still need some time to update the readme and other CI builds, and then I will merge it.

@hyrulelinks
Copy link
Contributor Author

The arm64 macOS-13-xlarge runner requires payment to use. Multiple attempts to set up an arm64 build environment on the x86_64 macOS-13 runner have failed. Therefore, for Apple users with M-chip, the quickest and most feasible option is to remotely script and package locally.

@hyrulelinks
Copy link
Contributor Author

Removed the renaming section, please review
@TransparentLC

@TransparentLC
Copy link
Owner

And the choice of using mirror site or not ...

@hyrulelinks
Copy link
Contributor Author

Add an option to "Do you want to use mirror site to clone repository", please review
@TransparentLC

@TransparentLC TransparentLC merged commit 41d4cb6 into TransparentLC:master Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants