Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANTA-4341 Optimize conditional object operations #382

Merged
merged 14 commits into from
Apr 9, 2020
Merged

MANTA-4341 Optimize conditional object operations #382

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6b2afa1
initial stubbing.
chudley Feb 14, 2020
52d5f91
limit test suite to one shard for now.
chudley Feb 25, 2020
d0de67c
more test suite stubbing.
chudley Feb 27, 2020
6fef55a
more test stubbing.
chudley Feb 27, 2020
bd16542
more tests.
chudley Mar 2, 2020
f3ccbd4
bad request test.
chudley Mar 4, 2020
55b116e
all shards tested. check passing for modified files only.
chudley Mar 5, 2020
536dcc1
back to one bucket, added helper in test suite to verify object hasn'…
chudley Mar 9, 2020
ddb618b
test suite full speed ahead for maximum shard capacity.
chudley Mar 13, 2020
9afbd86
add a 404 test to confirm removal of notFoundHandler.
chudley Mar 17, 2020
8367619
Merge branch 'buckets' into dev-MANTA-4341
chudley Mar 17, 2020
64702b7
failing tests on node versions lower than 13. confidence in these te…
chudley Mar 31, 2020
7208a6c
review feedback: remove commented bits, proper err response from HEAD…
chudley Apr 9, 2020
31c8aba
Merge branch 'buckets' into dev-MANTA-4341
chudley Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/buckets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1239,7 +1239,13 @@ function headBucketObject(bucketName, objectName, opts, cb) {
}

res.once('end', function onEnd() {
cb(null, res);
/*
* XXX Need to include `resErr` here because in the case of
* a HEAD request that fails precondition checks, it looks
* like we're currently also getting `res`. I don't know if
* that's normal or not.
*/
cb(resErr, res);
});

res.resume();
Expand Down
11 changes: 11 additions & 0 deletions test/integration/buckets-client-basic.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,17 @@ test('buckets client basic', testOpts, function (suite) {
});
});

test('headBucketObject (not found)', function (t) {
clientMethodsToTest.delete('headBucketObject');
client.headBucketObject(BUCKET_NAME, OBJECT_NAME + '-not-found',
function (err, res) {
t.ok(err);
t.ok(res);
t.ok(res.statusCode, 404);
t.end();
});
});

test('getBucketObject', function (t) {
clientMethodsToTest.delete('getBucketObject');
client.getBucketObject(BUCKET_NAME, OBJECT_NAME,
Expand Down
Loading