Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop getting iFrame dups and only inject into Iframes if including iframes #173

Merged
merged 4 commits into from
Jul 14, 2021

Conversation

TroyWalshProf
Copy link
Owner

No description provided.

@TroyWalshProf TroyWalshProf marked this pull request as ready for review July 12, 2021 23:41
Copy link
Collaborator

@dbjorge dbjorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part of the change affecting the iframe injection looks good to me, but had one question about an unrelated-looking part of the changes

@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TroyWalshProf TroyWalshProf merged commit 29d7dfc into main Jul 14, 2021
@TroyWalshProf TroyWalshProf deleted the bug/iFrameInjectionAndDoubleCount branch July 14, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants