Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Matcher 'to be called' #233

Merged
merged 11 commits into from
Apr 28, 2020
Merged

Add Matcher 'to be called' #233

merged 11 commits into from
Apr 28, 2020

Conversation

Jozwiaczek
Copy link
Contributor

No description provided.

@Jozwiaczek Jozwiaczek added the Work in progress Work in progress label Apr 23, 2020
@Jozwiaczek Jozwiaczek linked an issue Apr 23, 2020 that may be closed by this pull request
expect(...).to.be.called #229
Closed
sz-piotr
sz-piotr suggested changes Apr 24, 2020
View reviewed changes
waffle-chai/src/matchers/ethCalledWith.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalledWith.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled.ts Outdated Show resolved Hide resolved
waffle-chai/test/contracts/Events.ts Show resolved Hide resolved
waffle-chai/test/matchers/ethCalledWith.test.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalledWith.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled.ts Outdated Show resolved Hide resolved
waffle-chai/src/index.ts Outdated Show resolved Hide resolved
@Jozwiaczek Jozwiaczek requested a review from sz-piotr April 27, 2020 07:41
sz-piotr
sz-piotr suggested changes Apr 27, 2020
View reviewed changes
waffle-chai/src/matchers/ethCalled/calledOnContractValidators.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled/calledOnContract.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled/calledOnContractValidators.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled/calledOnContractValidators.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled/calledOnContractValidators.ts Outdated Show resolved Hide resolved
waffle-chai/src/types.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled/calledOnContractWith.ts Outdated Show resolved Hide resolved
waffle-chai/src/matchers/ethCalled/calledOnContract.ts Outdated Show resolved Hide resolved
waffle-chai/test/matchers/ethCalled/calledOnContractValidators.test.ts Outdated Show resolved Hide resolved
waffle-chai/test/matchers/ethCalled/calledOnContractWith.test.ts Outdated Show resolved Hide resolved
@sz-piotr
Copy link
Contributor

Also rename the folder ethCalled to calledOnContract

@Jozwiaczek Jozwiaczek removed the Work in progress Work in progress label Apr 27, 2020
@sz-piotr sz-piotr merged commit 086917e into master Apr 28, 2020
@sz-piotr sz-piotr deleted the matcher-eth-called branch April 28, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sz-piotr sz-piotr sz-piotr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expect(...).to.be.called
2 participants
@Jozwiaczek @sz-piotr