fix(solid): fix transaction signing functions #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichar
force-pushed
the
fix/solid-signing-function-types
branch
from
cb2a88c to
0aad5f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Solid adapter's two signing functions returned by
useWallet–signTransactionsandtransactionSigner– were using optional chaining to satisfy TypeScript and handle potentially null values foractiveWallet(). But that meant the type signatures for those functions were a union including| undefined.This removes the need for optional chaining by first assigning the
activeWallet()return value to a variable and throwing an error if it is null.To verify it works correctly, this PR also adds test transaction signing capabilities in the Solid example app.