Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor codebase into separate files, and enable importsNotUsedAsValues: error #1266

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

cspotcode
Copy link
Collaborator

Refactoring into separate files continues the trend started by repl.ts. IIRC the contributor remarked that the codebase was difficult to understand because so much was in index.ts.

importsNotUsedAsValues: error just seems like a good idea, but I admit I don't have a strong reason for doing it.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1266 (45ec5a3) into main (5c6efa4) will increase coverage by 0.22%.
The diff coverage is 95.23%.

Impacted Files Coverage Δ
src/repl.ts 74.35% <ø> (ø)
src/transpilers/swc.ts 74.28% <ø> (ø)
src/util.ts 89.47% <89.47%> (ø)
src/configuration.ts 96.42% <96.42%> (ø)
src/bin.ts 91.66% <100.00%> (+0.07%) ⬆️
src/index.ts 78.35% <100.00%> (-2.27%) ⬇️
src/tsconfigs.ts 100.00% <100.00%> (ø)

@cspotcode cspotcode merged commit 62641d9 into main Mar 2, 2021
@cspotcode cspotcode added this to the 10.0.0 milestone May 15, 2021
@cspotcode cspotcode deleted the ab/refactor-into-separate-files branch October 11, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant