Add support for bash-completion #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisroyer
force-pushed
the
bash-comp-typesetting-tools
branch
from
27ed45f to
3d0d81d
Compare
This allows autocomplete when calling aegisub from terminal. Before this commit, when having for example `file.webm` and `file.ass` in the directory, both were proposed while only the later could be open using CLI argument.
louisroyer
force-pushed
the
bash-comp-typesetting-tools
branch
from
3d0d81d to
eeb91e4
Compare
CoffeeFlux
reviewed
Feb 9, 2025
| @@ -26,3 +26,4 @@ option('update_server', type: 'string', value: 'https://aegisub-updates.redvice. | |||
| option('update_url', type: 'string', value: '/trunk', description: 'Base path to use for the update checker') | |||
|
|
|||
| option('build_osx_bundle', type: 'boolean', value: false, description: 'Package Aegisub.app on OSX') | |||
| option('bash_completion', type: 'boolean', value: true, description: 'Install bash shell completions') | |||
There was a problem hiding this comment.
Won't this run by default on Windows? I don't think I can merge this as-is.
There was a problem hiding this comment.
I don't have a Windows system to test. I added a new commit to disable this for Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows autocomplete when calling aegisub from terminal. Before this commit, when having for example
file.webmandfile.assin the directory, both were proposed while only the later could be open using CLI argument.