-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify heartbeats + annotate alerts (#1282)
### Changelist <!-- Give a list of the changes covered in this PR. This will help both you and the reviewer keep this PR within scope. --> A few changes that should make driving less fragile. 1. Changed the heartbeat dependency graph. Now, board A only checks the heartbeat of board B if A uses a signal from board B. There currently are a few instances of boards checking other boards' heartbeats, but then not actually using signals from them. In my mind this is unnecessary and could only lead to unnecessary faults down the line. (check me on this!). This for example means the FSM and BMS checks no other boards heartbeats. 2. Moved various faults on the VC related to the LV battery and currents to warnings. If `AccumulatorRailOvercurrentFault` and `BatteryRailOvercurrentFault` is set, we'd probably see total loss of the LV bus, so no need to just exit drive state. If just one is set, there is no immediate reason to stop driving. If there is a `LvChargeFault` or `BoostControllerFault`, there is also no need to exit drive state (we'd probably only notice the consequences of the failure on the next power cycle). By making these faults instead of warnings we reduce the chances of spurious shutdowns. 3. Added descriptions for all alerts. ### Testing Done <!-- Outline the testing that was done to demonstrate the changes are solid. This could be unit tests, integration tests, testing on the car, etc. Include relevant code snippets, screenshots, etc as needed. --> Unit testing only.
- Loading branch information
1 parent
1f82a39
commit b2d8cbe
Showing
22 changed files
with
196 additions
and
401 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,10 @@ | ||
{ | ||
"messages": [ | ||
"RSM_Vitals", | ||
"VC_Vitals", | ||
"BRUSA_Vitals", | ||
"Debug_Charging", | ||
"Debug_CanMode", | ||
"Debug_CellBalancing", | ||
"Debug_ResetSoc" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
{ | ||
"messages": [ | ||
"BMS_Vitals", | ||
"Debug_CanMode" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.