Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade STM32CubeMX version from 5.3.0 -> 6.9.2 #1016

Merged
merged 30 commits into from
Nov 1, 2023

Conversation

gtaharaedmonds
Copy link
Contributor

@gtaharaedmonds gtaharaedmonds commented Oct 10, 2023

Summary

Upgrade the boards in our repo from STM32CubeMX 5.3.0 to 6.9.2. We need to switch to 6.9.2 to unlock support for the STM32H7xx family of microcontrollers, which is going to be on our vehicle controller this year. Also, we should just upgrade since they probably fixed a bunch of bugs.

TODO: Test this on other people's machines

Changelist

  • Migrate every board's .ioc file from 5.3.0 to 6.9.2. This means we had to regenerate the drivers/middleware for every board, leading to a crazy diff.
  • Switch to CMSIS-RTOS v2, which is supported in 6.9.2 (it wasn't in 5.3.0). CMSIS-RTOS is an API that wraps FreeRTOS, and v2 is way easier to use than regular FreeRTOS and way more powerful than v1.
  • Bumped the version in the container (using a custom tag currently so ubcformulaelectric/environment still points to the regular container, and other CI jobs can run).

Testing Done

  • Flashed all boards and spun wheels on jacks
  • This is a big change, so lets do some driving with these changes

Resolved Issues

Checklist

Please change [ ] to [x] when you are ready.

  • I have read and followed the code conventions detailed in README.md (This will save time for both you and the reviewer!).
  • If this pull request is longer then 500 lines, I have provided explicit justification in the summary above explaining why I cannot break this up into multiple pull requests (Small PR's are faster and less painful for everyone involved!).

@gtaharaedmonds gtaharaedmonds changed the title upgrade version for dim Upgrade STM32CubeMX version Oct 10, 2023
@Lucien950 Lucien950 added the Build System/DevEx Anything that affects Build System, IDE Integration, Github Actions, Code Deployment label Oct 11, 2023
@Lucien950 Lucien950 self-requested a review October 11, 2023 16:37
Copy link
Contributor

@Lucien950 Lucien950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few optimization things.

.github/workflows/bin-dbc-gen.yml Outdated Show resolved Hide resolved
environment/Dockerfile Show resolved Hide resolved
environment/Dockerfile Outdated Show resolved Hide resolved
environment/Dockerfile Outdated Show resolved Hide resolved
@Lucien950
Copy link
Contributor

Lucien950 commented Oct 11, 2023

Also I am not familiar about autogenerated STM files but can they autogenerate on each build? (If so can we hide it away in build_arm)

@gtaharaedmonds gtaharaedmonds changed the title Upgrade STM32CubeMX version Upgrade STM32CubeMX version from 5.3.0 -> 6.9.2 Oct 14, 2023
@gtaharaedmonds gtaharaedmonds force-pushed the gus/upgrade_stm32cubemx_version branch from a7dea8b to 84532e8 Compare October 14, 2023 01:33
@gtaharaedmonds
Copy link
Contributor Author

gtaharaedmonds commented Oct 14, 2023

Also I am not familiar about autogenerated STM files but can they autogenerate on each build? (If so can we hide it away in build_arm)

Possibly yes. Currently we invoke CubeMX with the generate code command which just updates main.c and a few other files. We can also invoke with the project generate which should also update all driver files. Although Cube seems to not like being generated in a different directory than the .ioc so I'm not sure if we can put it in build_arm.

This'll be easier after the refactor since all CubeMX stuff will live in its own folder.

@gtaharaedmonds gtaharaedmonds force-pushed the gus/upgrade_stm32cubemx_version branch from d1a7b34 to 2e6d9e9 Compare October 24, 2023 20:06
@Lucien950
Copy link
Contributor

I'll review once #1040 gets merged in.

@gtaharaedmonds gtaharaedmonds merged commit 40ebf1d into master Nov 1, 2023
@gtaharaedmonds gtaharaedmonds deleted the gus/upgrade_stm32cubemx_version branch November 1, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build System/DevEx Anything that affects Build System, IDE Integration, Github Actions, Code Deployment
Development

Successfully merging this pull request may close these issues.

2 participants