Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending messages from VC properly without proper filtering #1284

Merged
merged 48 commits into from
May 28, 2024
Merged

Sending messages from VC properly without proper filtering #1284

merged 48 commits into from
May 28, 2024

Conversation

forbesashli
Copy link
Contributor

Changelist

telem files and seperation of can files in tasks

Testing Done

tested on hardware

Resolved Tickets

n/a

forbesashli and others added 30 commits May 4, 2024 17:12
@forbesashli
starting branch
e06484e
@forbesashli
uh
7bc11fe
@forbesashli
can msg io start of refactor
4af3bf1
@forbesashli
can fixes (thanks edwin)
681f923
@forbesashli
proto restructured
0ada72b
@larakawasme @forbesashli
in progress signalutil and proto on python side
6404695
@larakawasme
in progress sigutil
5444456
@larakawasme
adjusted telem.py to compile proto and run generate loockup
4b94360
@larakawasme
Sigutil needs to be tested with radios and backend running
5f8e95f
@larakawasme
Sigutil needs to be tested with radios and backend running
05f9887
@forbesashli
environment updated
d6ec6f6
@forbesashli
pyserial fix
c262bba
@forbesashli
pipfile update
6b86024
@larakawasme
removed automation of generate lookup
2503135
@forbesashli
minor changes
98429d3
@larakawasme
chnage get signal fn to search based off message description, not id
569b86a
@larakawasme
Adding threading
daac42b
@larakawasme
Merge branch 'master' into larak/signalUtil
5939041
@larakawasme
can fixes (ashlis bad)
dfb5752
@larakawasme
working to see messages from vc
7e30e1c
@larakawasme
Some changes
d10439c
@larakawasme
Passing file to ZEdwin to change sturcture of can database
e55918b
@Lucien950
querying works now!!!
ad7b065
@Lucien950
pass tests??
8a90f14
@Lucien950
JSONCAN restore functionality
0340067
@forbesashli
put on vc, some signals recieved
3b43169
@forbesashli
canTx changes
0d5ddef
@forbesashli
Merge branch 'master' into ashforb/protorestructure
494a3eb
@forbesashli
first pass
237e2c2
@forbesashli
packing moved around
6c5220b
gtaharaedmonds
gtaharaedmonds approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@gtaharaedmonds gtaharaedmonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Some stuff to clean up but I will do that ASAP in another PR
Thanks for making this!

@gtaharaedmonds gtaharaedmonds enabled auto-merge (squash) May 28, 2024 22:25
@gtaharaedmonds gtaharaedmonds merged commit 329f7a7 into master May 28, 2024
27 checks passed
@gtaharaedmonds gtaharaedmonds deleted the canUnpack branch May 28, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtaharaedmonds gtaharaedmonds gtaharaedmonds approved these changes

@larakawasme larakawasme Awaiting requested review from larakawasme

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@forbesashli @gtaharaedmonds @larakawasme @Lucien950