Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSM HW/IO Implementation #1358

Open
wants to merge 60 commits into
base: master
Choose a base branch
from
Open

RSM HW/IO Implementation #1358

wants to merge 60 commits into from

Conversation

pranay-o
Copy link
Contributor

@pranay-o pranay-o commented Oct 19, 2024 •
edited
Loading

Changelist

HW/IO implementation of RSM

Testing Done

None

Resolved Tickets

FIRM-150

@pranay-o pranay-o self-assigned this Oct 22, 2024
@pranay-o pranay-o changed the title C++ refactor of RSM leds and fans RSM refactor Oct 22, 2024
@pranay-o pranay-o changed the title RSM refactor RSM Refactor Oct 22, 2024
Jugveer-Sandher
Jugveer-Sandher reviewed Oct 26, 2024
View reviewed changes
Copy link
Contributor

@Jugveer-Sandher Jugveer-Sandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Just some small changes.

firmware/quintuna/RSM/src/io/io_loadCell.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_fans.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_fans.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_fans.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_fans.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_fans.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_loadCell.cpp Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_loadCell.cpp Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_fans.h Outdated Show resolved Hide resolved
@Jugveer-Sandher
Copy link
Contributor

Jugveer-Sandher commented Oct 26, 2024 •
edited
Loading

Also you need to fix some of your code formatting. Run this command from the Consolidated-Firmware root directory python3 scripts/utilities/fix_formatting.py

Jugveer-Sandher
Jugveer-Sandher reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Jugveer-Sandher Jugveer-Sandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the git checks are failing might want to look into why.

firmware/quintuna/RSM/src/io/io_loadCell.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_loadCell.cpp Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_leds.cpp Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_fans.h Outdated Show resolved Hide resolved
@pranay-o pranay-o added the FSM/RSM Sensor Module ECUs label Nov 1, 2024
Jugveer-Sandher
Jugveer-Sandher approved these changes Nov 2, 2024
View reviewed changes
firmware/quintuna/RSM/src/io/io_leds.cpp Outdated Show resolved Hide resolved
@pranay-o pranay-o force-pushed the pranay-o/RSM_brake_fan_refactor branch 2 times, most recently from c8579d0 to 7399a31 Compare November 2, 2024 20:44
Lucien950
Lucien950 requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Lucien950 Lucien950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a few issues, but very close, and a very excellent firstish production PR.

Please talk to me if you have any questions. :)

firmware/quintuna/RSM/src/io/io_loadCell.cpp Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_loadCell.cpp Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_loadCell.cpp Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_loadCell.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_leds.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_leds.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_leds.cpp Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_fans.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/hw/hw_gpios.cpp Outdated Show resolved Hide resolved
@Lucien950 Lucien950 changed the title RSM Refactor RSM ADC/GPIO port, LEDS, FANs, LOADCELLS Nov 12, 2024
@pranay-o pranay-o changed the title RSM ADC/GPIO port, LEDS, FANs, LOADCELLS RSM GPIO port, LEDS, FANs, LOADCELLS Nov 16, 2024
@pranay-o pranay-o changed the title RSM GPIO port, LEDS, FANs, LOADCELLS RSM GPIO port, LEDS, FANs, LOADCELLS, MAINSTATE Nov 16, 2024
@pranay-o pranay-o force-pushed the pranay-o/RSM_brake_fan_refactor branch from ec9f229 to 27fb989 Compare November 16, 2024 22:24
@rijwal rijwal changed the title RSM RSM Bringup Jan 12, 2025
Lucien950
Lucien950 requested changes Jan 14, 2025
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_suspension.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_suspension.h Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_suspension.c Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_suspension.c Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/hw/hw_gpios.h Show resolved Hide resolved
firmware/quintuna/RSM/src/hw/hw_pwms.c Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_coolants.c Outdated Show resolved Hide resolved
firmware/quintuna/RSM/src/hw/hw_pwms.c Show resolved Hide resolved
firmware/quintuna/RSM/src/io/io_coolants.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double check we are working with the same coolant device.
i dont' think this one has pressure, please double check this

@Lucien950 Lucien950 changed the title RSM Bringup RSM HW/IO Implementation Jan 19, 2025
Lucien950
Lucien950 reviewed Jan 28, 2025
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucien950 Lucien950 Lucien950 requested changes

@AmirTajaddodi AmirTajaddodi Awaiting requested review from AmirTajaddodi

@Jugveer-Sandher Jugveer-Sandher Awaiting requested review from Jugveer-Sandher

Requested changes must be addressed to merge this pull request.

Assignees

@rijwal rijwal

@pranay-o pranay-o

Labels
FSM/RSM Sensor Module ECUs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pranay-o @Jugveer-Sandher @Lucien950 @rijwal @AmirTajaddodi