USB Middleware #1365
Merged
USB Middleware #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-ilan
added
Drivers
liam-ilan
force-pushed
the
liam-ilan/usb
branch
2 times, most recently
from
ef5dbfd to
2f9424b
Compare
Lucien950
requested changes
Nov 12, 2024
There was a problem hiding this comment.
I am lowkey leaning on not using the STM generated stuff for CDC level of USB at least cause it seems very big and confusing.
Is the delieverable here to have any communication between USB and STM? I assume in a later PR you will do the migration for Chimera from UART to USB.
Overall very good work, and I look forward to the demo on software-dubs
|
Whoops - should have left this as draft, need to bring back that |
liam-ilan
force-pushed
the
liam-ilan/usb
branch
from
2f9424b to
c860ec1
Compare
Lucien950
requested changes
Dec 2, 2024
firmware/cmake/stmlib.cmake
Outdated
| @@ -81,9 +84,16 @@ function(stm32f412rx_cube_library | |||
| "${SEGGER_SYSTEMVIEW_SOURCE_DIR}/Sample/FreeRTOSV10" | |||
| ) | |||
|
|
|||
| file(GLOB USB_SRCS | |||
There was a problem hiding this comment.
no glob required
please move to line 126
There was a problem hiding this comment.
actually why this cause down there it's the same files
…d USB_ENABLED flag.
Lucien950
approved these changes
Dec 7, 2024
DJ90864
pushed a commit
that referenced
this pull request
Dec 7, 2024
### Changelist - Added USB middleware flag to stm32 h7 and f4 binary building functions. - Setup USB Echo Program on F4 and H7 (H7 not tested due to clock misconfiguration). ### Testing Done - USB Device Appears as device when plugged into computer (f4dev). - Able to communicate with f4dev via pyusb (@setaremalekiii). - h7dev untested, to be done when clock configs fixed. - Ran subsequent `hw_usb` library on top of this one, usb comms working awesome. ### Resolved Tickets [FIRM-159](https://ubcformulaelectric.atlassian.net/browse/FIRM-159) [FIRM-159]: https://ubcformulaelectric.atlassian.net/browse/FIRM-159?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Testing Done
hw_usblibrary on top of this one, usb comms working awesome.Resolved Tickets
FIRM-159