Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adi/gps error handling #1399

Merged
merged 47 commits into from
Jan 18, 2025
Merged

Adi/gps error handling #1399

merged 47 commits into from
Jan 18, 2025

Conversation

Aditya-Dhiman4
Copy link
Contributor

@Aditya-Dhiman4 Aditya-Dhiman4 commented Nov 30, 2024

Changelist

Added IMU functions for obtaining angular velocity in io_imu.c
Added velocity calculations in app_sbgEllipse.c
Added getter function for EKF Solution Mode in io_sbgEllipse.c
Added new CAN messages for calculated velocity, IMU angular velocity, and EKF Solution Mode

Testing Done

Velocity Calculation was tested on the car, corrected formula accordingly.
IMU outputs reasonable angular velocities based on second VC, more rigorous testing should be done in the future.
Wrote unit tests for velocity calculation.

Resolved Tickets

can_bus/quadruna/VC/VC_tx.json Outdated Show resolved Hide resolved
can_bus/quadruna/VC/VC_tx.json Outdated Show resolved Hide resolved
can_bus/quadruna/VC/VC_tx.json Outdated Show resolved Hide resolved
firmware/quadruna/VC/src/app/app_sbgEllipse.c Outdated Show resolved Hide resolved
firmware/quadruna/VC/src/app/app_sbgEllipse.c Show resolved Hide resolved
Copy link
Contributor

@philam2001 philam2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create some unit testing for your changes

@Aditya-Dhiman4 Aditya-Dhiman4 marked this pull request as ready for review January 13, 2025 22:24
can_bus/quadruna/VC/VC_tx.json Show resolved Hide resolved
firmware/quadruna/VC/src/app/app_sbgEllipse.c Outdated Show resolved Hide resolved
firmware/quadruna/VC/src/app/app_sbgEllipse.c Outdated Show resolved Hide resolved
firmware/quadruna/VC/src/app/app_sbgEllipse.c Outdated Show resolved Hide resolved
firmware/quadruna/VC/test/test_velocityCalculation.cpp Outdated Show resolved Hide resolved
firmware/quadruna/VC/src/app/app_sbgEllipse.c Outdated Show resolved Hide resolved
can_bus/quadruna/VC/VC_tx.json Outdated Show resolved Hide resolved
firmware/quadruna/VC/src/io/io_sbgEllipse.c Outdated Show resolved Hide resolved
firmware/quadruna/VC/src/io/io_sbgEllipse.c Show resolved Hide resolved
firmware/quadruna/VC/src/app/app_sbgEllipse.c Outdated Show resolved Hide resolved
firmware/quadruna/VC/src/app/app_sbgEllipse.c Outdated Show resolved Hide resolved
@Aditya-Dhiman4 Aditya-Dhiman4 merged commit e1a903a into master Jan 18, 2025
33 checks passed
@Aditya-Dhiman4 Aditya-Dhiman4 deleted the adi/gps-error-handling branch January 18, 2025 22:27
AmirTajaddodi pushed a commit that referenced this pull request Jan 19, 2025
### Changelist 
Added IMU functions for obtaining angular velocity in io_imu.c
Added velocity calculations in app_sbgEllipse.c
Added getter function for EKF Solution Mode in io_sbgEllipse.c
Added new CAN messages for calculated velocity, IMU angular velocity,
and EKF Solution Mode

### Testing Done
Velocity Calculation was tested on the car, corrected formula
accordingly.
IMU outputs reasonable angular velocities based on second VC, more
rigorous testing should be done in the future.
Wrote unit tests for velocity calculation.

### Resolved Tickets
<!-- Link any tickets that this PR resolves. -->

---------

Co-authored-by: Kyle Mackenzie <[email protected]>
Co-authored-by: Phi Lam <[email protected]>
Co-authored-by: Edwin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants