-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adi/gps error handling #1399
Merged
Merged
Adi/gps error handling #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aElectric/Consolidated-Firmware into adi/gps-error-handling
philam2001
requested changes
Nov 30, 2024
Aditya-Dhiman4
commented
Nov 30, 2024
…idated-Firmware into adi/gps-error-handling
…y, added bool for future velocity switching logic
philam2001
requested changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create some unit testing for your changes
…irmware into adi/gps-error-handling
philam2001
requested changes
Jan 15, 2025
philam2001
requested changes
Jan 15, 2025
philam2001
requested changes
Jan 18, 2025
philam2001
approved these changes
Jan 18, 2025
…irmware into adi/gps-error-handling
AmirTajaddodi
pushed a commit
that referenced
this pull request
Jan 19, 2025
### Changelist Added IMU functions for obtaining angular velocity in io_imu.c Added velocity calculations in app_sbgEllipse.c Added getter function for EKF Solution Mode in io_sbgEllipse.c Added new CAN messages for calculated velocity, IMU angular velocity, and EKF Solution Mode ### Testing Done Velocity Calculation was tested on the car, corrected formula accordingly. IMU outputs reasonable angular velocities based on second VC, more rigorous testing should be done in the future. Wrote unit tests for velocity calculation. ### Resolved Tickets <!-- Link any tickets that this PR resolves. --> --------- Co-authored-by: Kyle Mackenzie <[email protected]> Co-authored-by: Phi Lam <[email protected]> Co-authored-by: Edwin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Added IMU functions for obtaining angular velocity in io_imu.c
Added velocity calculations in app_sbgEllipse.c
Added getter function for EKF Solution Mode in io_sbgEllipse.c
Added new CAN messages for calculated velocity, IMU angular velocity, and EKF Solution Mode
Testing Done
Velocity Calculation was tested on the car, corrected formula accordingly.
IMU outputs reasonable angular velocities based on second VC, more rigorous testing should be done in the future.
Wrote unit tests for velocity calculation.
Resolved Tickets