Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic hw_usb Transmit Handle #1419

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Generic hw_usb Transmit Handle #1419

merged 1 commit into from
Jan 11, 2025

Conversation

liam-ilan
Copy link
Contributor

Changelist

  • Pass transmit_handle as an argument to hw_usb/hw_usb_init.
  • Will let us pass both HS and FS handlers (ie. H7 vs. F4)

Testing Done

None (H7Dev not working right now due to unrelated issues).

Resolved Tickets

None.

@liam-ilan liam-ilan self-assigned this Jan 11, 2025
gtaharaedmonds
gtaharaedmonds approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@gtaharaedmonds gtaharaedmonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liam-ilan liam-ilan merged commit 9c2cea6 into master Jan 11, 2025
29 checks passed
@liam-ilan liam-ilan deleted the liam-ilan/hs-usb-support branch January 11, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJ90864 DJ90864 DJ90864 approved these changes

@gtaharaedmonds gtaharaedmonds gtaharaedmonds approved these changes

@Lucien950 Lucien950 Awaiting requested review from Lucien950

Assignees

@liam-ilan liam-ilan

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liam-ilan @gtaharaedmonds @DJ90864