Cortex-M7 compiler flag fix #1432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtaharaedmonds
requested review from
liam-ilan and
Lucien950
and removed request for
liam-ilan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Looks like I made a mistake when setting up the compiler flags for Cortex-M7s and we've been passing
-mcpu=cortex-m4. They both support the same instruction set (which I believe this flag is responsible for configuring) which is probably why we haven't seen any issues. However, we should definitely correct this regardless. There are differences in the final binaries so this definitely does something...Testing Done